fix(apollo): replace jcip annotations dependency#222
Merged
yshyn-iohk merged 1 commit intoMay 19, 2026
Conversation
Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
|
patextreme
approved these changes
May 18, 2026
patextreme
left a comment
There was a problem hiding this comment.
Verified locally:
net.jcip:jcip-annotationsis completely absent from all dependency configurations ✅com.github.stephenc.jcip:jcip-annotations:1.0-1(Apache 2.0) is present as replacement ✅org.bitcoinj:bitcoinj-corebumped to0.17.1✅- Fix applied consistently to both JVM and Android source sets ✅
bitcoinjcorecatalog entry intentionally retained for future simplification ✅
The only build failure (:bip32-ed25519:buildRustWrapper) is pre-existing and unrelated to this PR.
elribonazo
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
org.bitcoinj:bitcoinj-corefrom0.17to0.17.1net.jcip:jcip-annotationsfrom the bitcoinj dependencycom.github.stephenc.jcip:jcip-annotations:1.0-1as the Apache-licensed replacement for JVM and Android source setsWhy
Apollo issue #192 tracks the licensing problem caused by the transitive runtime dependency on
net.jcip:jcip-annotations.The upstream bitcoinj change referenced in the issue comments exists in commit
8070bd80e6897684d004137a388990b75e946c2f, but the latest published artifact available today,org.bitcoinj:bitcoinj-core:0.17.1, still ships thenet.jcip:jcip-annotations:1.0runtime dependency. This PR fixes Apollo now without waiting for a future bitcoinj release.Validation
./gradlew :apollo:dependencies --configuration jvmRuntimeClasspathorg.bitcoinj:bitcoinj-core:0.17.1is presentnet.jcip:jcip-annotationsis no longer presentcom.github.stephenc.jcip:jcip-annotations:1.0-1is present instead./gradlew :apollo:compileKotlinJvm --no-configuration-cache --max-workers=1:bip32-ed25519:buildRustWrapper(lipo: can't move temporary file ... libuniffi_ed25519_bip32_wrapper.dylib.lipo)Follow-up
Once bitcoinj publishes a release that includes the upstream removal of
net.jcip:jcip-annotations, Apollo should be able to simplify this by dropping the explicit exclusion and replacement dependency.Fixes #192