Skip to content

feat(webhooks): add confirmationMode subscription option - #1772

Merged
peterbroadhurst merged 3 commits into
mainfrom
webhooks-confirmation-mode
Aug 5, 2026
Merged

feat(webhooks): add confirmationMode subscription option#1772
peterbroadhurst merged 3 commits into
mainfrom
webhooks-confirmation-mode

Conversation

@EnriqueL8

Copy link
Copy Markdown
Contributor

Proposed changes

Fixes #1770


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

- Adds a `confirmationMode` enum naming the three delivery-confirmation
behaviors explicitly:

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8
EnriqueL8 requested a review from a team as a code owner August 5, 2026 17:19
peterbroadhurst
peterbroadhurst previously approved these changes Aug 5, 2026

@peterbroadhurst peterbroadhurst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @EnriqueL8 - very minor comment, but no functional concerns.

Particularly liked the Markdown docs updated on the confirmation modes. Think that's a great addition to help users choose the right mode.

Comment thread internal/events/webhooks/webhooks.go Outdated
Comment thread internal/events/webhooks/webhooks.go
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
internal/coremsgs/en_error_messages.go 0.00% <ø> (ø)
internal/coremsgs/en_struct_descriptions.go 0.00% <ø> (ø)
internal/events/webhooks/webhooks.go 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterbroadhurst
peterbroadhurst merged commit 19b1158 into main Aug 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhooks transport has no way to hold the subscription checkpoint on delivery failure, propose a confirmationMode option

2 participants