feat(webhooks): add confirmationMode subscription option - #1772
Merged
Conversation
- Adds a `confirmationMode` enum naming the three delivery-confirmation behaviors explicitly: Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
peterbroadhurst
previously approved these changes
Aug 5, 2026
peterbroadhurst
left a comment
Contributor
There was a problem hiding this comment.
This looks great to me @EnriqueL8 - very minor comment, but no functional concerns.
Particularly liked the Markdown docs updated on the confirmation modes. Think that's a great addition to help users choose the right mode.
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
peterbroadhurst
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1770
Types of changes
Please make sure to follow these points