fix(webhooks): hold subscription checkpoint on non-2xx delivery - #1769
Closed
EnriqueL8 wants to merge 2 commits into
Closed
fix(webhooks): hold subscription checkpoint on non-2xx delivery#1769EnriqueL8 wants to merge 2 commits into
EnriqueL8 wants to merge 2 commits into
Conversation
Webhook delivery previously acknowledged every event regardless of the HTTP response, so a failed delivery (non-2xx, or a network error synthesised as a 502) advanced the subscription checkpoint and the event was never redelivered. Also adds INFO-level logging of the outcome and the checkpoint offset(s), so delivery success/hold is visible without enabling debug logging, and error FF10486 for the held-delivery case. Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Initial investigation into a bug on webhooks
Types of changes
Please make sure to follow these points