feat: added a way to get error messages#138
Open
duncan412 wants to merge 3 commits intohyperized:masterfrom
Open
feat: added a way to get error messages#138duncan412 wants to merge 3 commits intohyperized:masterfrom
duncan412 wants to merge 3 commits intohyperized:masterfrom
Conversation
Owner
|
Hi @duncan412, I'm not willing to change the interface on this to return a string, I don't want to burden the client with having to parse both. I would accept throwing an exception, is that something that you could do? |
Owner
|
Come to think of it, alternatively, I would also accept having a method that you can use to retrieve the error code from that you can optionally call. |
…e and added functions to get errors
Author
|
Sorry for my late response! I reverted my changes and added a way to catch the exception and get information from it. Could this work for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.