Repository navigation
fix(sink): dead-letter records over the producer ceiling on bus - #173
Merged
Merged
Conversation
On the bus transport, a filter dropped records over the sink's message.max.bytes and counted them in component_discarded_events_total. That broke at-least-once delivery.
Records within message.max.bytes go to the sink. Larger records go through a remap into scalo's DLQ entry, then to a second Kafka sink on sink.dlq_topic. The default topic is dfe_transform_dlq, which dfe-loader loads.
- the entry has service, reason, attempts, original_bytes, the first bytes as base64 and the _org_id, _source, _timestamp_received and _tags values that fit
- the first bytes and copied values share dlq.max_payload_bytes, held to half of what message.max.bytes leaves
- the DLQ sink takes the main sink's brokers, credentials and librdkafka options
- it writes JSON with no key
- it blocks when its buffer is full instead of dropping
- dlq.enabled false keeps the filter and its drop count
- vector_component_sent_events_total{component_id="dfe_dlq_sink"} counts the dead letters
- pipeline_dead_letters_dropped_total{reason="too_large"} counts those the DLQ sink rejected
Tests cover:
- the generator over json and raw_bytes
- the remap through vector vrl
- two e2e cases that read the entry back from the DLQ topic
# Conflicts: # docs/internals.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the bus transport, a filter dropped records over the sink's message.max.bytes and counted them in component_discarded_events_total. That broke at-least-once delivery.
Records within message.max.bytes go to the sink. Larger records go through a remap into scalo's DLQ entry, then to a second Kafka sink on sink.dlq_topic. The default topic is dfe_transform_dlq, which dfe-loader loads.
Tests cover: