Repository navigation
fix(sink): set the producer compression codec once - #167
Merged
Merged
Conversation
Vector writes sink.compression as compression.codec. The generator also wrote compression.type. librdkafka reads both as one setting. rdkafka applies a client's options in hash order. With compression.codec: gzip in sink.librdkafka_options, 30 starts of Vector 0.61.0 on the generated sink gave 12 gzip and 18 zstd. The generated sink alone gave 30 zstd, because both spellings carried the same value. The sink sets the codec once through Vector's compression field. It drops compression.codec and compression.type from the profile's librdkafka_options. Both spellings are derived options, so config validation rejects either in sink.librdkafka_options.
The profile constants file is in scalo-rs. The hyperi-ci doc-paths check treats the path in docs/librdkafka.md as a missing local file. Replace the path with a link to that file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector writes sink.compression as compression.codec. The generator also wrote compression.type. librdkafka reads both as one setting. rdkafka applies a client's options in hash order.
With compression.codec: gzip in sink.librdkafka_options, 30 starts of Vector 0.61.0 on the generated sink gave 12 gzip and 18 zstd. The generated sink alone gave 30 zstd, because both spellings carried the same value.
The sink sets the codec once through Vector's compression field. It drops compression.codec and compression.type from the profile's librdkafka_options. Both spellings are derived options, so config validation rejects either in sink.librdkafka_options.