Repository navigation
fix(sink): dead-letter events over the per-message budget - #187
Merged
Merged
Conversation
An event over sink.max_message_bytes after serialisation was dropped. It was logged and counted on events_oversize_total. Enrichment grows an event about 1.5 times. A near-cap input could go over the cap and be lost, breaking at-least-once delivery. Each oversize event goes to the DLQ as its whole serialised body. The reason names its size and the budget. The entry is keyed to the sink topic like the not-JSON dead letters. The DLQ cuts the body to dlq.max_payload_bytes and records original_bytes. The source is released once the DLQ holds the entry. events_oversize_total still counts each oversize event. With dlq.enabled false, oversize events are dropped and counted in pipeline_dead_letters_dropped_total, like the not-JSON ones. serialise_events keeps its signature for tests and offline tools. The service calls serialise_events_with_oversize, which hands the oversize bodies back.
catinspace-au
added a commit
that referenced
this pull request
Nov 16, 2026
Main's #187 sends an event over sink.max_message_bytes to the DLQ. The architecture page keeps the branch's layout. Its one-record paragraph names serialise_events_with_oversize and the DLQ. The configuration page uses main's DLQ wording and the branch's word choices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping events over sink.max_message_bytes after serialisation broke at-least-once delivery. Enrichment could push a near-cap input over the cap.
Oversize events go to the DLQ:
Tests: unit tests in pipeline.rs cover the returned body and the reason. tests/direct_transport.rs pushes an oversize event beside one that fits and reads the file DLQ.