Repository navigation
fix(tls): run every listener on scalo ServerTls - #274
Draft
catinspace-au wants to merge 2 commits into
Draft
catinspace-au wants to merge 2 commits into
catinspace-au wants to merge 2 commits into
Conversation
Each listener's tls block loads into scalo's ServerTls. This covers /ingest, webhook, Splunk HEC, remote write, OTLP HTTP and gRPC, Vector gRPC, syslog, Fluent Forward, GELF and Lumberjack. The next handshake uses the rotated certificate, key or client CA without a restart. Before, only a secret-backed certificate reloaded, and only on five listeners. - The sync and async acceptor builders, the RwLock certificate provider, the tonic identity loader and five copies of the handshake-with-timeout block are gone. - The receiver handles the handshake instead of tonic. Failed gRPC handshakes count towards receiver_tls_handshake_failures_total. The connection cap applies before the handshake. - Config loading rejects a certificate, key or CA set as both a file and a secret. It used to prefer the secret. - scalo is pinned to the commit that adds ServerTls until a release has it, so deny.toml allows that git source. Closes #270
tls.refresh_interval_secs is unset by default, so ServerTls reloads on scalo's interval instead of the receiver's 3600. A value set in the config still wins. The example config, config schema and tests match this default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scalo-rs#472 is merged but unreleased. scalo uses a git rev until ServerTls ships.
Certificate, key and client CA rotation works from files or secrets without a restart. Handshakes use the rotated values from the next handshake. Before, only a secret-backed certificate reloaded, and only on five listeners.
Tests: lib 963 pass. tls_reload tests rotation for each family (hyper, raw TCP, tonic) with both a file and a file: secret. It sends a gRPC and an OTLP request over the receiver's handshake. With reload off the three rotation tests fail. tls_openssl (Docker, every listener, plain and mTLS) and the vault TLS tests pass.
Release is blocked until the git rev is replaced with a scalo release that has ServerTls and allow-git is removed from deny.toml.
Closes #270