Skip to content

fix(dfe-extras): wire the hunt auto-disable settings - #1127

Merged
catinspace-au merged 1 commit into
mainfrom
fix/hunt-autodisable
Nov 16, 2026
Merged

catinspace-au merged 1 commit into
mainfrom
fix/hunt-autodisable

Conversation

@catinspace-au

Copy link
Copy Markdown
Collaborator

dfe-engine 2.2.3 stops a hunt that keeps tripping a ClickHouse resource limit (hyperi-io/dfe-engine#1191). It is on by default, with 3 failures in 3600 s. huntRunner.autodisable.enabled, failures and windowSeconds set it. All three default to empty, which takes the engine's default.

The hunt runner alone reads these settings and gets the variables. A switch set to false renders "false", since the engine default is on. A value the engine can't parse fails the render with its values path. The render rejects a count under 1.

With nothing set, no variable renders and the golden files stay unchanged. test_hunt_autodisable.py covers unset, set, off and rejected values on both pods. The auto-disable section in autoscaling.md starts with the status.

dfe-engine 2.2.3 stops a hunt that keeps tripping a ClickHouse resource limit (hyperi-io/dfe-engine#1191). It is on by default, with 3 failures in 3600 s. huntRunner.autodisable.enabled, failures and windowSeconds set it. All three default to empty, which takes the engine's default.

The hunt runner alone reads these settings and gets the variables. A switch set to false renders "false", since the engine default is on. A value the engine can't parse fails the render with its values path. The render rejects a count under 1.

With nothing set, no variable renders and the golden files stay unchanged. test_hunt_autodisable.py covers unset, set, off and rejected values on both pods. The auto-disable section in autoscaling.md starts with the status.
@catinspace-au
catinspace-au merged commit 0d0c500 into main Nov 16, 2026
15 checks passed
@catinspace-au
catinspace-au deleted the fix/hunt-autodisable branch November 16, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant