Repository navigation
fix(dfe-extras): wire the hunt auto-disable settings - #1127
Merged
Merged
Conversation
dfe-engine 2.2.3 stops a hunt that keeps tripping a ClickHouse resource limit (hyperi-io/dfe-engine#1191). It is on by default, with 3 failures in 3600 s. huntRunner.autodisable.enabled, failures and windowSeconds set it. All three default to empty, which takes the engine's default. The hunt runner alone reads these settings and gets the variables. A switch set to false renders "false", since the engine default is on. A value the engine can't parse fails the render with its values path. The render rejects a count under 1. With nothing set, no variable renders and the golden files stay unchanged. test_hunt_autodisable.py covers unset, set, off and rejected values on both pods. The auto-disable section in autoscaling.md starts with the status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dfe-engine 2.2.3 stops a hunt that keeps tripping a ClickHouse resource limit (hyperi-io/dfe-engine#1191). It is on by default, with 3 failures in 3600 s. huntRunner.autodisable.enabled, failures and windowSeconds set it. All three default to empty, which takes the engine's default.
The hunt runner alone reads these settings and gets the variables. A switch set to false renders "false", since the engine default is on. A value the engine can't parse fails the render with its values path. The render rejects a count under 1.
With nothing set, no variable renders and the golden files stay unchanged. test_hunt_autodisable.py covers unset, set, off and rejected values on both pods. The auto-disable section in autoscaling.md starts with the status.