Repository navigation
docs(values): point argocd/values comments at the docs - #1126
Merged
Merged
Conversation
argocd/values/ comments drop from 1327 lines to 317. Of those, 211 point to a docs page or give a short reason beside a surprising value. Another 66 sit in the fragment and seeded-app blocks that scripts/composition.py rewrites. The other 40 are shell and Python comments inside the engine's init-container scripts. These scripts are string values. The explanations move into three pages linked from docs/deployment/README.md: - values-shared.md for common.yaml - values-clouds-edge.md for the cloud and edge flavour files - values-tiers-apps.md for the tier profiles and per-app files Every edited YAML file loads to the same value before and after. composition.py --check-fragments passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments in argocd/values/ point to docs pages or give short reasons beside surprising values.
Of the 317 comments:
211 are pointers or short reasons
66 sit in the fragment and seeded-app blocks composition.py rewrites
40 are shell and Python comments in the engine's init-container scripts (string values)
every edited file loads to the same value before and after (yaml.safe_load, 62 of 62)
the render goldens are unchanged
the staging example file is untouched