Repository navigation
fix(sync): hold the lockfile at main's versions - #229
Merged
Merged
Conversation
The 2.45 sync took upstream's whole lockfile and skipped step 5 of the cycle. This downgraded packages main had moved past upstream. #228 restored those behind alerts. This restores the other downgraded packages and stops sync downgrades. The 16 restored packages are the @babel/* copies, @jridgewell/sourcemap-codec, @types/semver, axios, is-core-module, isexe, regenerate, resolve and smol-toml. The restored versions are within their declared ranges, resolved by yarn up -R. package.json is unchanged. osv-scanner reports no issues before and after. scripts/lockfile-floor.py compares yarn.lock with the base branch and names every package that resolves lower, by descriptor and by major line. The sync workflow runs yarn up -R on those names, then fails if any is still below. fork-surface.yml runs the same check on every PR. Intentional downgrades go in security/lockfile-floor-allow.txt with a reason.
Contributor
|
Released in v0.3.26 -- https://github.com/hyperi-io/dfe-hyperdx/releases/tag/v0.3.26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.45 sync took upstream's lockfile whole and skipped the yarn up -R step. #228 put back the packages behind alerts. This restores the other downgraded packages and fails future syncs if package versions fall below the base branch.
One yarn up -R command fixes all 122 package regressions in the 2.45 merge's lockfile. osv-scanner reports no issues before and after.