Repository navigation
fix(sources): show a capped hunt run's summary row as its counts - #227
Merged
Merged
Conversation
A rule that fills its per-run detection cap leaves one summary row with the nil matched_uuid and the counts in _json. In Hunt Results that row read as a match with a zero UUID. The hunts source's default select shows a `match` column. Summary rows show counts, such as "capped: 27 matched, 20 written". Match rows show the UUID.
The results cell truncates at about 20 characters, which hid the cap behind "capped: 21 matched, ...". The shorter form shows both numbers at the default width.
Contributor
|
Released in v0.3.26 -- https://github.com/hyperi-io/dfe-hyperdx/releases/tag/v0.3.26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rule that reaches its per-run detection cap leaves one summary row in dfe.detection. That row has nil matched_uuid and counts in _json. The demo packs cap at 20. The theatre's vessel rule matches 21 to 27 per run.
Hunt Results showed the summary row with a zero UUID that looked like a broken match.
The hunts source's default select shows a
matchcolumn in place of matched_uuid. A summary row shows "capped: 27 matched, 20 written". A match shows its UUID. The change is limited to that select and its test.The seed runs for a team with no sources. A seeded deployment keeps the old column until its DocumentDB is fresh.
org-connection.test.ts: 65 passed on desktop-derek with common-utils built.
Before and after screenshots of the live theatre pack: /projects/dfe-engine/.hyperi-ai/tmp/ui-capped-shots/ on dragonfly. The after screenshot shows the replacement select in the embedded search.