Repository navigation
fix(rest): report the manifest items a max_items cap skips - #315
Merged
Merged
Conversation
A unit that reads no window and marks no items stopped at max_items without warning. For go_modules, this dropped every version of a module past the 100th. The proxy's list is not in version order. The tick reads and counts the rest of the page. It logs a warning with the skipped count and the first 20 ids. It adds the count to dfe_fetcher_manifest_items_skipped_total. Units that read a window, dumps and units with item marks behave as before. Closes #314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A unit that reads no window and marks no items stopped at max_items without warning. For go_modules, this dropped every version of a module past the 100th. The proxy's list is not in version order.
The tick reads and counts the rest of the page. It logs a warning with the skipped count and the first 20 ids. It adds the count to dfe_fetcher_manifest_items_skipped_total.
Units that read a window, dumps and units with item marks behave as before.
Closes #314