Repository navigation
fix(ci): run the db-odbc test suites on every pull request - #313
Merged
Merged
Conversation
odbc-api 30 replaces StatementParent with KeepConnectionOpen. Nothing in crates/db names either type, so no source change is needed. Cargo.lock holds odbc-api 30.0.0 and arrow-odbc 27.0.0. They are the newest releases past the 7-day cooldown. encoding_rs 0.8.44 and log 0.4.35 move with them because arrow-odbc 27 needs both. Supersedes #304.
The test stage left db-odbc out, so the ODBC dump and tail suites ran nowhere. odbc-api 30 was compiled but never exercised. hyperi-ci installs unixodbc-dev, odbc-postgresql and odbc-mariadb on the runner when Cargo.lock names odbc-sys. db-odbc joins the third test set. No extra job is needed. A missing driver fails the test in CI. The SQL Server and Oracle suites still skip by name without their proprietary drivers. CONTRIBUTING.md and docs/testing.md say so.
catinspace-au
added a commit
that referenced
this pull request
Nov 16, 2026
The lock pins these versions. Both are the newest past the 7-day cooldown. No source changes. #313: ODBC tests passed with these versions: - PostgreSQL and MariaDB dump and tail - Postgres to Kafka path - Driver unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ODBC dump and tail suites ran nowhere, so the odbc-api 30 and arrow-odbc 27 bump in #312 was only compiled. This adds db-odbc to the Test feature sets.
Done when the db-odbc suites pass in the Test job against PostgreSQL and MariaDB containers.