Repository navigation
fix(appmgmt): send dump units to the source's topic - #1192
Open
catinspace-au wants to merge 1 commit into
Open
catinspace-au wants to merge 1 commit into
catinspace-au wants to merge 1 commit into
Conversation
dfe-fetcher lands a dump unit on `<topic>-<unit>`. The engine creates only the topic and table `<source>`. Dump unit rows went to the default table. The compiled config for a keyed fetcher family (rest, db, file) sets `topic_per_dump_unit` to false. Every unit goes to the source's topic. A source's fetcher config cannot set the key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fetcher source with a
shape: dumpunit lost its rows todfe.main. dfe-fetcher wrote the unit to<source>-<unit>_landand stamped_sourcethe same. The engine creates only<source>_landand the table<source>.topic_per_dump_unit: false. Every unit lands on the source's topic and table.fetcher.configcannot set the key,enabledortopic.Tests: the key is set on rest, db and file and refused in source config. 2216 tests pass under tests/unit/test_appmgmt, test_source and the app contract tests. dfe-fetcher#316 tests the data path with the compiled config.