Repository navigation
fix(engine): fix test, unused argument and docstrings - #1190
Merged
Merged
Conversation
The live pipeline e2e test waited for a ddl/<table>.sql file the engine never writes. It checks the source's YAML in the deploy repo's config/sources/, where the engine commits it. resolve_mode drops its require_pr argument, which no caller passed. The provider catalogue docstring named a dfe-infra providers.yaml that does not exist. It names the providers.yaml shipped beside the module. The get_current_user docstring said auth defaults off. It defaults on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live pipeline e2e test waited for a ddl/
.sql file the engine never writes. It checks the source's YAML in the deploy repo's config/sources/, where the engine commits it.resolve_mode drops its require_pr argument, which no caller passed.
The provider catalogue docstring named a dfe-infra providers.yaml that does not exist. It names the providers.yaml shipped beside the module.
The get_current_user docstring said auth defaults off. It defaults on.