Skip to content

fix(engine): fix test, unused argument and docstrings - #1190

Merged
catinspace-au merged 1 commit into
mainfrom
fix/docs-review-findings
Nov 16, 2026
Merged

catinspace-au merged 1 commit into
mainfrom
fix/docs-review-findings

Conversation

@catinspace-au

Copy link
Copy Markdown
Contributor

The live pipeline e2e test waited for a ddl/

.sql file the engine never writes. It checks the source's YAML in the deploy repo's config/sources/, where the engine commits it.

resolve_mode drops its require_pr argument, which no caller passed.

The provider catalogue docstring named a dfe-infra providers.yaml that does not exist. It names the providers.yaml shipped beside the module.

The get_current_user docstring said auth defaults off. It defaults on.

The live pipeline e2e test waited for a ddl/<table>.sql file the engine never writes. It checks the source's YAML in the deploy repo's config/sources/, where the engine commits it.

resolve_mode drops its require_pr argument, which no caller passed.

The provider catalogue docstring named a dfe-infra providers.yaml that does not exist. It names the providers.yaml shipped beside the module.

The get_current_user docstring said auth defaults off. It defaults on.
@catinspace-au
catinspace-au merged commit 5d4e20b into main Nov 16, 2026
19 checks passed
@catinspace-au
catinspace-au deleted the fix/docs-review-findings branch November 16, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant