Repository navigation
fix(update): remove the previous stack images after a nightly update - #406
Merged
Merged
Conversation
Self-update left a full set of images from the old pin after each update. The VM disk reached 92%. - Before the re-pin it lists the images docker compose resolves to across all profiles. - After make ci and its self test pass, it runs docker image rm on each one the new stack no longer names and no container uses. - Images pulled by hand are not touched. - A failed update removes nothing. - A removal error logs a warning and the update still succeeds.
A previous pin of x:1 and a new pin of x:1@sha256:abc are one image. The string comparison treated them as different images. docker image rm x:1 could therefore untag an image the new stack uses. Each reference matches name:tag and, if it has a digest, name@digest. A previous image is kept if either form matches the new stack or a container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-update left a full set of images from the old pin after each update. The VM disk reached 92%.