Skip to content

fix(post): check dfe-ui's metrics and correct stale comments - #404

Merged
catinspace-au merged 3 commits into
mainfrom
fix/docs-pass-code-findings
Nov 15, 2026
Merged

catinspace-au merged 3 commits into
mainfrom
fix/docs-pass-code-findings

Conversation

@catinspace-au

@catinspace-au catinspace-au commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Five code fixes and a dial key rename. Related: #403.

  • post.py: add dfe-ui to OTEL_PUSHER_PREFIXES because it pushes metrics. The live dfe-docker stack (dfe-ui v1.7.45) holds 70 dfe-ui rows in dfe.otel_metrics_gauge. Stacks on dfe-ui v1.7.39 or older do not push, so make post fails on them. Update the test and the table in docs/observability.md to match.
  • post.py: the no-tables failure names dfe-engine, which creates the otel tables.
  • check_compose.py: the 2.0 CPU floor stays. The comment states that scalo-rs polls Kafka on tokio's blocking pool. Lowering the floor needs a healthcheck run at 1.5 CPU on a current image.
  • deployment.example.yaml: hyperdx_enabled and otel_enabled are true, as in every profile.
  • PROVENANCE.md: tests/fixtures/unencumbered/ is in the dfe-transform-elastic repo.
  • The dial's top-level key is platform (docker-vm | k8s). scripts/render_dial.py reads it. It rejects the old key with no fallback. dfe-infra renames its side in a paired PR and both merge together.

Gates: make check-python, check-docs, check-compose, and scripts/tests.

The self test checks dfe-ui's metrics like the other pushers. dfe-ui pushes metrics over OTLP/HTTP under the ServiceName dfe-ui. On the live dfe-docker stack running dfe-ui v1.7.45, dfe.otel_metrics_gauge held 70 dfe-ui rows from the last ten minutes.

The no-tables failure names dfe-engine because it creates the otel tables. The collector runs with create_schema false.

The CPU floor comment in check_compose.py drops the synchronous Kafka poll explanation. scalo-rs polls on tokio's blocking pool. The CPU floor stays unchanged without data to support lowering it.

deployment.example.yaml sets hyperdx_enabled and otel_enabled to true, matching every profile in service_profiles.yaml. Its prose calls the target a platform. PROVENANCE.md names the repo that holds tests/fixtures/unencumbered/.
scripts/render_dial.py reads the dial's top-level `platform` key (docker-vm | k8s). The example and test dial have `platform`. The rejection message says platform.

The old key is not read. There is no fallback. A deployment.yaml with the old key is rejected with the same message as any other wrong value. A test covers the retired key, a k8s platform and a missing key.

dfe-infra's dial reader and example move to the same key in a paired change.
dfe-ui pushes metrics from v1.7.40. `make post` expects dfe-ui rows only when DFE_UI_VERSION is v1.7.40 or later. A 2.2.1 stack pins v1.7.34 and no longer fails the check. An unset or local version is still checked.

A dial with `substrate:` fails with a message explaining the rename to `platform:`. A dial missing `platform:` reports the missing key. Both cases are in the render_dial tests.

The e2e otel message names dfe-engine, which creates those tables.
@catinspace-au
catinspace-au merged commit e4464ea into main Nov 15, 2026
16 checks passed
@catinspace-au
catinspace-au deleted the fix/docs-pass-code-findings branch November 15, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant