Repository navigation
fix(post): check dfe-ui's metrics and correct stale comments - #404
Merged
Merged
Conversation
The self test checks dfe-ui's metrics like the other pushers. dfe-ui pushes metrics over OTLP/HTTP under the ServiceName dfe-ui. On the live dfe-docker stack running dfe-ui v1.7.45, dfe.otel_metrics_gauge held 70 dfe-ui rows from the last ten minutes. The no-tables failure names dfe-engine because it creates the otel tables. The collector runs with create_schema false. The CPU floor comment in check_compose.py drops the synchronous Kafka poll explanation. scalo-rs polls on tokio's blocking pool. The CPU floor stays unchanged without data to support lowering it. deployment.example.yaml sets hyperdx_enabled and otel_enabled to true, matching every profile in service_profiles.yaml. Its prose calls the target a platform. PROVENANCE.md names the repo that holds tests/fixtures/unencumbered/.
scripts/render_dial.py reads the dial's top-level `platform` key (docker-vm | k8s). The example and test dial have `platform`. The rejection message says platform. The old key is not read. There is no fallback. A deployment.yaml with the old key is rejected with the same message as any other wrong value. A test covers the retired key, a k8s platform and a missing key. dfe-infra's dial reader and example move to the same key in a paired change.
dfe-ui pushes metrics from v1.7.40. `make post` expects dfe-ui rows only when DFE_UI_VERSION is v1.7.40 or later. A 2.2.1 stack pins v1.7.34 and no longer fails the check. An unset or local version is still checked. A dial with `substrate:` fails with a message explaining the rename to `platform:`. A dial missing `platform:` reports the missing key. Both cases are in the render_dial tests. The e2e otel message names dfe-engine, which creates those tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five code fixes and a dial key rename. Related: #403.
platform(docker-vm | k8s). scripts/render_dial.py reads it. It rejects the old key with no fallback. dfe-infra renames its side in a paired PR and both merge together.Gates: make check-python, check-docs, check-compose, and scripts/tests.