Skip to content

fix(compose): give the engine the image digests the stack runs - #402

Merged
catinspace-au merged 3 commits into
mainfrom
fix/engine-stack-images
Nov 15, 2026
Merged

catinspace-au merged 3 commits into
mainfrom
fix/engine-stack-images

Conversation

@catinspace-au

Copy link
Copy Markdown
Contributor

The engine names the stack by matching the digests it is told about against the published stack manifests. Compose passed only the build's stack name. This names the wrong stack when two stacks share the same app digests.

DFE_ENGINE_STACK_IMAGES lists the ten DFE app images Compose runs. It uses the same interpolations as the image lines, so the list matches those images. DFE_ENGINE_STACK_VERSION stays as the offline fallback.

check_compose checks that the list holds exactly those images, each by digest.

The engine names the stack by matching the digests it is told about against the published stack manifests. Compose passed only the build's stack name. This names the wrong stack when two stacks share the same app digests.

DFE_ENGINE_STACK_IMAGES lists the ten DFE app images Compose runs. It uses the same interpolations as the image lines, so the list matches those images. DFE_ENGINE_STACK_VERSION stays as the offline fallback.

check_compose checks that the list holds exactly those images, each by digest.
The dev overlay from make dev and LOCAL= repoints images to :local. The engine still received the registry digests in DFE_ENGINE_STACK_IMAGES, so it reported a published stack while running local builds.

When the overlay repoints any image, it clears DFE_ENGINE_STACK_IMAGES on dfe-engine. The engine then reports DFE_ENGINE_STACK_VERSION. The overlay is unchanged when nothing is built.
The overlay from make dev and LOCAL= sets DFE_ENGINE_STACK_IMAGES to empty on the engine. This makes the console show DFE_STACK_VERSION on a local build.
@catinspace-au
catinspace-au merged commit 2c5cc48 into main Nov 15, 2026
16 checks passed
@catinspace-au
catinspace-au deleted the fix/engine-stack-images branch November 15, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant