Repository navigation
fix(compose): give the engine the image digests the stack runs - #402
Merged
Merged
Conversation
The engine names the stack by matching the digests it is told about against the published stack manifests. Compose passed only the build's stack name. This names the wrong stack when two stacks share the same app digests. DFE_ENGINE_STACK_IMAGES lists the ten DFE app images Compose runs. It uses the same interpolations as the image lines, so the list matches those images. DFE_ENGINE_STACK_VERSION stays as the offline fallback. check_compose checks that the list holds exactly those images, each by digest.
The dev overlay from make dev and LOCAL= repoints images to :local. The engine still received the registry digests in DFE_ENGINE_STACK_IMAGES, so it reported a published stack while running local builds. When the overlay repoints any image, it clears DFE_ENGINE_STACK_IMAGES on dfe-engine. The engine then reports DFE_ENGINE_STACK_VERSION. The overlay is unchanged when nothing is built.
The overlay from make dev and LOCAL= sets DFE_ENGINE_STACK_IMAGES to empty on the engine. This makes the console show DFE_STACK_VERSION on a local build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine names the stack by matching the digests it is told about against the published stack manifests. Compose passed only the build's stack name. This names the wrong stack when two stacks share the same app digests.
DFE_ENGINE_STACK_IMAGES lists the ten DFE app images Compose runs. It uses the same interpolations as the image lines, so the list matches those images. DFE_ENGINE_STACK_VERSION stays as the offline fallback.
check_compose checks that the list holds exactly those images, each by digest.