Repository navigation
docs(deploy-repo): fix claims about dfe-infra and dfe-engine - #37
Merged
Merged
Conversation
A pins.yaml bump does not move the base. Argo CD renders from the cluster secret's target_revision. dfe-ops upgrade apply moves the pin and target_revision. Bootstrap creates the bundled Forgejo repo without this template (dfe-infra#13). - the schema overlay variable is DFE_ENGINE_SCHEMAS_OVERLAY_DIR - an invoke against a missing instance file creates it with its deploy block, so it deploys the instance - dfe-engine and its hunt runner read config/, not the other apps - the data ApplicationSet reads sizing/ straight from this repo, under infra/ - the infra/ file list matches the ApplicationSets - dfe-schema.yaml is removed - the values cascade lists every layer the ApplicationSets stack - each storage model states its storage.md status - the AWS bucket takes precedence over an infra/ overlay - engine seeding of governance/ and .seed-ignore are documented The repo's top diagram is added to docs/README.md. Config comments in pins.yaml, both workflows and the validator requirements are cut to pointers and short reasons. The governance/ YAML stays byte-identical to dfe-engine's seeded copies.
The table lists argocd/values/apps/ and the culvert instance files as inputs to the edge tunnel ApplicationSet, matching the apps ApplicationSet (dfe-infra layer2-edge.yaml). The edge gateway alone reads infra/<app>.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 30 incorrect claims and add 2 missing claims across the README, CONTRIBUTING, docs/ and directory READMEs. Of 100 claims, 64 match dfe-infra's appsets, charts and scripts and dfe-engine's source. The other 4 depend on Argo CD or Kubernetes behaviour.
dfe-ops upgrade apply --pushupdates both pins.yaml and target_revision.DFE_ENGINE_SCHEMAS_OVERLAY_DIR. The documented name did nothing.sizing/straight from the repo, so nothing needs copying intoinfra/.Restore the bootstrap-seeding status dropped by #31 as the dfe-infra#13 note. Restore the README's "Read by" column as the values cascade table. Keep #32 to #35.
Fix three false arrows in the 1 Mermaid diagram that failed the checker's source pass. The 1 diagram in docs/README.md returns
ok 975x298 nodes=7 arrows=6on Mermaid 12.3.0.Trim config comments to pointers and short reasons in pins.yaml, both workflows and tools/requirements-validate.txt. The governance/ YAML stays byte-identical to dfe-engine's seeded copies.
Merge leaves the published site alone until a stack pins a newer dfe-deploy tag.