build(deps): bump rustls to 0.23.45 for RUSTSEC-2026-0285 - #293
Merged
Merged
Conversation
cargo-deny now fails every CI run on RUSTSEC-2026-0285: rustls 0.23.43 accepted TLS 1.3 handshake messages sent at the wrong encryption level after a key change in the same record. The handshake transcript stays authenticated, so the practical effect was accepting plaintext messages that should have been encrypted rather than a forged handshake, but the advisory gate blocks the release lane regardless. The precise bump also moves aws-lc-sys 0.42.0 to 0.45.0 and rustls-webpki 0.103.13 to 0.103.15, all with a 1.71 MSRV. The Hue driver, the smallest rustls dependent, check-compiles against the new aws-lc-sys. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Cargo.lockmoves rustls from 0.23.43 to 0.23.45, which also takes aws-lc-sys from 0.42.0 to 0.45.0 and rustls-webpki from 0.103.13 to 0.103.15. No source changes.Why
RUSTSEC-2026-0285 landed in the advisory database and
cargo denynow fails every CI run on main, which blocks the release lane (the tag lane needsrust-deny). rustls 0.23.43 accepted TLS 1.3 handshake messages sent at the wrong encryption level after a key change in the same record; the fix is 0.23.45. The transcript stays authenticated, so this was never a forged-handshake path, but the gate is the gate.Verification
cargo deny checkin the bumped tree: advisories, bans, licenses, and sources all ok.cargo check -p hypercolor-driver-hue(the smallest rustls dependent) compiles the new aws-lc-sys 0.45.0 and finishes clean.All three crates declare a 1.71 MSRV, below the workspace's 1.94.
The full workspace build and test run is CI's job on this PR; it was not run locally.
Added or updated tests (not applicable; lockfile only)
Added or updated docs (not applicable)
just verifypasses locally (not run; CI covers the workspace build)just denypasses (required for dependency or license changes)just ui-testandjust ui-buildpass (not applicable)just sdk-lint,just sdk-check, andjust sdk-buildpass (not applicable)just python-verifypasses (not applicable)just compat-checkpasses (not applicable)just docs-buildpasses (not applicable)cd docs && zola checkpasses (not applicable)Packaging scripts were syntax-checked (not applicable)
just e2e-buildpasses with the normal Servo stack (not applicable)just e2e-build-cpupasses when validating the CPU smoke fallback (not applicable)just e2epasses against the Servo stack (not applicable)Tested on real hardware, simulator, or e2e harness (not applicable)
Notes for reviewers
aws-lc-sys is a C build, so the Windows and macOS lanes are the ones worth watching on this PR. A plain
cargo update -p rustlsresolved nothing under the MSRV-aware resolver; the bump uses--precise 0.23.45.🤖 Generated with Claude Code
https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou