feat(scene): guard selected-field activation and persistence evidence - #289
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Automation can supersede a scene's context, layout, and brightness independently. Add an explicit selected-field operation that preserves omitted state and validates the observed scene at each owning admission boundary without implicitly waking output. Carry authored scene fences through renderer layout publication and retain exact precommit and rollback payload outcomes. Brightness returns its original settings persistence result under the shared output and scene guards. Partial failures preserve earlier admission evidence. Cover all field combinations, stale definitions, edits after prewrite, rollback failure, brightness durability failures, and media admission. Keep existing scene activation and connected-display behavior covered. Co-Authored-By: Nova (GPT-6) <noreply@openai.com>
The post-replacement directory-sync failure hook on AtomicFileWriter only exists on unix, so the Windows nextest build of this integration test failed to compile. Gate the test the same way the sibling persistence tests in output_power_tests.rs and library.rs already do. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014466GJcZeEz2om6JDZ3Chm
hyperb1iss
force-pushed
the
nova/product-experience-engine
branch
from
September 13, 2026 17:12
a3addfe to
1201eea
Compare
hyperb1iss
force-pushed
the
nova/smart-home-engine-guards
branch
from
September 13, 2026 17:12
7dbaac6 to
5377da6
Compare
hyperb1iss
marked this pull request as ready for review
September 13, 2026 17:19
hyperb1iss
changed the base branch from
nova/product-experience-engine
to
main
September 13, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Guarded scene activation accepts an explicit selection of context, layout, and brightness. Omitted fields and power stay unchanged. Results preserve the original persistence evidence, including a layout prewrite and its rollback when later publication rejects the request.
This layer stacks on #287 (
nova/product-experience-engine).Why
Smart-home commands need to reject stale scene context at the actual mutation boundary and report whether their own writes persisted. Layout validation now crosses the renderer publication boundary without holding a read lock across a renderer write. Brightness follows the existing transition and settings lock order.
Verification
just verifypasses locally (focused gates passed; full recipe pending)just denypasses (not run for this layer)just ui-testandjust ui-buildpass (no UI changes)just sdk-lint,just sdk-check, andjust sdk-buildpass (no SDK changes)just python-verifypasses (no Python changes)just compat-checkpasses (no device database changes)just docs-buildpasses (no documentation changes)cd docs && zola checkpasses (no documentation changes)just e2e-buildpasses with the normal Servo stack (combined artifact qualification pending)just e2e-build-cpupasses (not run for this layer)just e2epasses against the Servo stack (installed execution pending)Notes for reviewers
A drained retry queue cannot certify the exact original write. The result retains the candidate and rollback payloads and their original outcomes. Tests cover authored edits after prewrite, restart rollback, brightness write failures, and escaped candidate writes when rollback fails.
This draft does not complete the private catalog, guarded executor, or Alexa/Google integration. The tests also leave broader queued-writer, output-transition, and superseded-write acceptance scenarios for further qualification.