fix(ci): require Windows validation before release builds - #280
Merged
Conversation
Artifact builders did not depend on the Windows test job, allowing a failed native check to coexist with publication. Require that job for both builders and cover the dependency in the workflow contract test. Join the owner-publication fixture after lock release instead of giving filesystem completion one second. A scoped publisher preserves the store during unwind and retains the existing lock-exclusion assertion. Co-Authored-By: Nova (GPT-6) <noreply@openai.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request adds Windows Rust checks to two release job prerequisites, updates coverage assertions for those dependencies, and replaces timeout-based synchronization in a macOS owner concurrency test with scoped threads and explicit publication signaling. ChangesCI release gating
Owner concurrency test
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release builders now require the Windows test job. Previously a failed Windows run could still allow artifact publication because neither builder depended on it.
The owner-publication fixture also stops treating slow filesystem completion as an ownership failure. Its one-second deadline could unwind the test while a detached publisher still used the temporary directory. A scoped publisher now joins after lock release, preserving the directory and the existing 50ms assertion that publication stays blocked during the stop request.
An injected 1.2-second publication delay reproduces the old failure and passes with the repair. All 50 runnable owner-crate tests, Clippy, formatting, four workflow contract tests, and Actionlint pass. Independent review passed and independently reran all 25 coordinator tests plus the workflow checks.
The refreshed 0.5.0 tag passed the full Windows job: 3,998 shared tests, 32 capture/input fixtures, allocation checks, and 1,808 daemon integration tests. The owner-publication regression passed on that native runner. These repairs affect tests and CI only.