test(capture): keep fixture streams live across stale frames - #278
Merged
Conversation
A single synthetic frame can expire under scheduling pressure, leaving lifecycle tests with no subsequent frame to observe. Deliver fixture frames at 60fps until each observation completes, then stop and join the producer before crossing any reconfiguration boundary. Preserve stale-frame rejection and prove recovery with fresh pixels. Require new geometry and new content after a worker generation change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
hyperb1iss
added a commit
that referenced
this pull request
Sep 8, 2026
Merge the independently reviewed Windows fixture fix after native Windows validation. The separate Intel fixture repair follows in PR #278.
hyperb1iss
changed the base branch from
nova/windows-reclaim-fixture
to
main
September 8, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS capture lifecycle fixtures now supply an ongoing 60fps stream while waiting for an observation. Previously they supplied one frame. If that frame expired during scheduling pressure, production correctly rejected it and the test could never receive a replacement.
A controlled first-frame processing stall reproduces the failure: the old fixture receives one stale frame and fails its two-second wait. With ongoing delivery under the same stall, one frame is rejected and a fresh frame publishes in 80ms. Production freshness rules, capture rates, and observation deadlines are unchanged.
Each scoped producer stops and joins before reconfiguration. The generation test requires both new geometry and new green pixels, so old content cannot satisfy it. The stale-frame test still proves rejection before checking recovery.
Validation: all 14 fixture tests pass locally, including an independent run with eight test threads; scoped Clippy, formatting, and diff checks pass. Independent design review passed. Native Intel capture and interop fixtures pass, and the full Apple Silicon capability job passes. The refreshed 0.5.0 tag passed the complete Intel and Apple Silicon capability jobs, Windows validation, Servo tests, and both end-to-end suites.
The Windows GPU-fence fixture fix in #277 is merged. This change completes the two fixture repairs found during 0.5.0 release validation.