ci(hacs): ignore the brands check until the upstream listing lands - #2
Merged
Conversation
The repo went public, which lit up HACS validation on every push — and it fails on exactly one of eight checks: hypercolor is not yet listed in home-assistant/brands. That listing is an upstream submission (icon/logo assets reviewed by the HA team), not something this repo can satisfy from CI. Ignore only the brands check so the other seven keep enforcing; drop the ignore once the brands PR merges. signalrgb-homeassistant passes this same check via its existing custom_integrations/signalrgb entry. Co-Authored-By: Nova (Claude Fable 5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main went red when the repo flipped public: HACS validation now runs on every push and fails on exactly one of its eight checks — hypercolor isn't listed in home-assistant/brands yet. That listing is an upstream submission (icon + logo assets reviewed by the HA team), so no change in this repo can satisfy it.
This ignores only the
brandscheck, keeping the other seven enforcing. The ignore is explicitly temporary: drop the line once the brands submission merges. For reference, signalrgb-homeassistant passes the same check via its existingcustom_integrations/signalrgbbrands entry — hypercolor needs the equivalent (custom_integrations/hypercolorwithicon.png/icon@2x.png/logo.png/logo@2x.png).🤖 Generated with Claude Code