feat: taps should pass through when onTap is unset#32
Merged
BirjuVachhani merged 2 commits intohyper-designed:mainfrom Mar 26, 2025
Merged
feat: taps should pass through when onTap is unset#32BirjuVachhani merged 2 commits intohyper-designed:mainfrom
BirjuVachhani merged 2 commits intohyper-designed:mainfrom
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/hyper-designed/box_transform~32 Documentation is deployed and generated using docs.page. |
SaadArdati
requested changes
Mar 22, 2025
SaadArdati
approved these changes
Mar 22, 2025
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: Feature Request: TransformableBox should enable onTap Event Propagation to Child Widgets #31
Problem statement
Currently the
TransformableBoxcaptures all tap events and forwards them to the onTap callback. This becomes problematic if we want the content of theTransformableBoxto capture onTap events (or whatever is rendered behind the box, in case the content is ignoring pointer events).Testing
Manual testing have been performed with the following setup:
onTaparg was provided, the tap event was captured by the TransformableBox.onTaparg was not provided, the tap event was captured by the CameraPreview's GestureDetector.