Skip to content

feat: adopt Go 1.25 enhancements#10

Merged
hyp3rd merged 1 commit intomainfrom
codex/modernize-codebase-with-go-1.25-features
Aug 19, 2025
Merged

feat: adopt Go 1.25 enhancements#10
hyp3rd merged 1 commit intomainfrom
codex/modernize-codebase-with-go-1.25-features

Conversation

@hyp3rd
Copy link
Owner

@hyp3rd hyp3rd commented Aug 19, 2025

Summary

  • streamline metadata copying with maps.Clone
  • add ErrorGroup.Join plus slog logging adapter
  • document modern cloning and logging options

Testing

  • go test $(go list ./... | grep -v '/test$')

https://chatgpt.com/codex/tasks/task_e_68a43a8e4c7c8330bddc3f25e1e63248

Copilot AI review requested due to automatic review settings August 19, 2025 08:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adopts Go 1.25 enhancements to modernize the codebase by leveraging new standard library features for improved performance and developer experience.

  • Replace manual metadata copying with maps.Clone for cleaner code
  • Add ErrorGroup.Join method using errors.Join and modernize error cloning with slices.Clone
  • Introduce slog logging adapter with comprehensive documentation

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
errors.go Replaces manual metadata copying with maps.Clone for cleaner code
error_group.go Adds Join() method using errors.Join and modernizes Errors() with slices.Clone
error_group_test.go Adds test coverage for the new Join() method
pkg/ewrap/adapters/slog.go Implements new slog logging adapter for Go 1.21+
pkg/ewrap/adapters/slog_test.go Provides test coverage for the slog adapter
docs/docs/features/logging.md Documents the new slog integration
docs/docs/features/error-groups.md Updates documentation to recommend Join() over legacy methods
README.md Updates examples to use new Join() method and documents slog support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hyp3rd hyp3rd merged commit 433159a into main Aug 19, 2025
9 checks passed
@hyp3rd hyp3rd deleted the codex/modernize-codebase-with-go-1.25-features branch August 19, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants