Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adopts Go 1.25 enhancements to modernize the codebase by leveraging new standard library features for improved performance and developer experience.
- Replace manual metadata copying with
maps.Clonefor cleaner code - Add
ErrorGroup.Joinmethod usingerrors.Joinand modernize error cloning withslices.Clone - Introduce slog logging adapter with comprehensive documentation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| errors.go | Replaces manual metadata copying with maps.Clone for cleaner code |
| error_group.go | Adds Join() method using errors.Join and modernizes Errors() with slices.Clone |
| error_group_test.go | Adds test coverage for the new Join() method |
| pkg/ewrap/adapters/slog.go | Implements new slog logging adapter for Go 1.21+ |
| pkg/ewrap/adapters/slog_test.go | Provides test coverage for the slog adapter |
| docs/docs/features/logging.md | Documents the new slog integration |
| docs/docs/features/error-groups.md | Updates documentation to recommend Join() over legacy methods |
| README.md | Updates examples to use new Join() method and documents slog support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maps.CloneErrorGroup.Joinplussloglogging adapterTesting
go test $(go list ./... | grep -v '/test$')https://chatgpt.com/codex/tasks/task_e_68a43a8e4c7c8330bddc3f25e1e63248