Skip to content

fix: set callable name on RetryingCaller Prometheus labels - #146

Closed
ltsyk wants to merge 1 commit into
hynek:mainfrom
ltsyk:fix/retrying-caller-metric-name
Closed

fix: set callable name on RetryingCaller Prometheus labels#146
ltsyk wants to merge 1 commit into
hynek:mainfrom
ltsyk:fix/retrying-caller-metric-name

Conversation

@ltsyk

@ltsyk ltsyk commented Jul 30, 2026

Copy link
Copy Markdown

Summary

RetryingCaller / AsyncRetryingCaller always labeled Prometheus metrics as callable="<context block>" because they reused retry_context(), which hard-codes that name.

Change

Build the retry iterator via _RetryContextIterator.from_params(..., name=guess_name(callable_)) so metrics match the decorator path.

Test plan

  • Module imports after change
  • Instrumentation label now uses the real callable name

Fixes #110

RetryingCaller uses guess_name(callable_) for metrics (issue hynek#110)
@hynek

hynek commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Thank you for trying to contribute.

Given the current volume of LLM-assisted contributions, we cannot spend maintainer time reviewing pull requests that do not follow the project’s contribution process.

Before submitting further contributions, please read and follow this project’s CONTRIBUTING.md and AI_POLICY.md.

Thank you for your understanding!

@hynek hynek closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

*RetryingCaller doesn't set the underlying callable name for prometheus metrics

2 participants