Repository navigation
Fix/deployment validation - #15
Merged
Merged
Conversation
… what it did env.py never loaded the logging section alembic.ini declares, so 'alembic upgrade head' (the compose migrate step) printed nothing and an operator could not tell whether it applied six revisions or none. Load it only when Alembic was started from an ini file, so a Config built in code (the tests, schema.py) keeps the caller's logging untouched.
The api service depends on migrate, so 'docker compose run --rm api ...' ran 'alembic upgrade head' before every CLI command. After a build, a scheduled retention cleanup would migrate the database under the old api and worker, against the documented deploy order. With --no-deps the CLI only checks the schema revision, as the API and worker do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.