fix(ui): respect sort order; add 'status' sort mode#108
Merged
Conversation
Tabs were always reordered to push terminal-state processes (finished, stopped, failed, skipped) to the bottom, overriding sort: 'config' (and 'alphabetical'/'topological'). Reordering now only applies under the new sort: 'status' mode; explicit sort modes preserve their order strictly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 2.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sort: 'config'(and'alphabetical'/'topological').sort: 'status'mode. Existing explicit sort modes preserve their order strictly.Test plan
bun run typecheckbun test(670 passing)sort: 'status'is preservedsort: 'status'returns config order (reorder happens in TabBar)getDisplayOrderhelper tests retained — still drives'status'mode🤖 Generated with Claude Code