perf(ui): tail-render scrollback instead of full buffer#105
Merged
Conversation
Old code reset the terminal at 50k lines / 10MB to stop getJson() from freezing the event loop on verbose processes. Scrollback vanished each time the cap was hit. TailingTerminal subclasses GhosttyTerminalRenderable and patches the underlying getJson to inject offset = totalLines - limit, so each render extracts only the tail window (RENDER_LIMIT = 5000 lines) regardless of how much has been fed. Render cost is now O(limit), not O(buffer). Older lines stay in ghostty's native scrollback and will be reachable via scroll-up paging in a later phase. Raised OOM backstop thresholds 20x (50k to 1M lines, 10MB to 500MB) since render cost is no longer proportional to buffer size. The line check now uses our newline counter since terminal.lineCount is capped at RENDER_LIMIT. Upstream tracking: remorses/ghostty-opentui#7 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getJson()from freezing the event loop on verbose processes. Scrollback vanished each reset.TailingTerminalsubclass patchesGhosttyTerminalRenderable._persistentTerminal.getJsonto injectoffset = totalLines - limit, so rendering always extracts only the tail window (RENDER_LIMIT = 5000). Render cost isO(limit)regardless of buffer size.ScrollBoxso users can page through pre-tail history.Upstream tracking: remorses/ghostty-opentui#7
Test plan
bun test src/ui/pane.test.ts)bun run typecheck)bun run lint)bun run devagainst a noisy process (yes | head -200000); verify no freeze and tail lines visible🤖 Generated with Claude Code