refactor(dfir_rs,dfir_lang): remove schedule_subgraph's SubgraphId arg, no-op calls, and remove current_subgraph

[MingweiSamuel]

STACK: #2801

Remove the unused sg_id: SubgraphId parameter from
Context::schedule_subgraph — inline mode ignores it. Remove
Context::current_subgraph which always returned a dummy value.

Update all operator codegen call sites to drop the
#context.current_subgraph() argument.

[cloudflare-workers-and-pages]

Deploying hydro with    Cloudflare Pages

Latest commit:	08d7f92
Status:	✅  Deploy successful!
Preview URL:	https://a499fa70.hydroflow.pages.dev
Branch Preview URL:	https://mingwei-delete-schedule-subg.hydroflow.pages.dev

View logs

[Copilot]

Pull request overview

This PR simplifies the inline DFIR runtime/context API by removing subgraph-ID plumbing that was effectively unused in inline mode, and updates dfir_lang operator codegen accordingly.

Changes:

• Remove Context::current_subgraph() and drop the SubgraphId parameter from Context::schedule_subgraph(...).
• Update operator codegen call sites to stop passing #context.current_subgraph() and to use the new schedule_subgraph(bool) signature where needed.
• Adjust inline codegen in meta_graph to use the new scheduling API.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
dfir_rs/src/scheduled/context.rs	Removes current_subgraph and simplifies schedule_subgraph to only accept is_external.
dfir_lang/src/graph/ops/spin.rs	Updates to context.schedule_subgraph(true) with new signature.
dfir_lang/src/graph/ops/reduce_keyed.rs	Drops old scheduling call (now leaves an empty quote_spanned! arm).
dfir_lang/src/graph/ops/reduce.rs	Removes now-unused context binding and removes no-op iterator-after scheduling.
dfir_lang/src/graph/ops/persist_mut_keyed.rs	Drops old scheduling call (now leaves an empty write_iterator_after).
dfir_lang/src/graph/ops/persist_mut.rs	Drops old scheduling call (now leaves an empty write_iterator_after).
dfir_lang/src/graph/ops/persist.rs	Drops old scheduling call (now leaves an empty write_iterator_after).
dfir_lang/src/graph/ops/join_fused_lhs.rs	Removes no-op iterator-after scheduling logic.
dfir_lang/src/graph/ops/join_fused.rs	Removes now-unused context binding and no-op iterator-after scheduling logic.
dfir_lang/src/graph/ops/join.rs	Removes no-op iterator-after scheduling logic.
dfir_lang/src/graph/ops/fold_keyed.rs	Drops old scheduling call (now leaves an empty quote_spanned! arm).
dfir_lang/src/graph/ops/fold.rs	Removes now-unused context binding and removes no-op iterator-after scheduling.
dfir_lang/src/graph/ops/cross_join_multiset.rs	Drops old scheduling call (now leaves dead replay_code / empty tokens).
dfir_lang/src/graph/meta_graph.rs	Updates generated inline tick code to call df.schedule_subgraph(true) with new signature.

Comments suppressed due to low confidence (1)

dfir_lang/src/graph/ops/cross_join_multiset.rs:120

• replay_code is now generated as an empty TokenStream (only a comment remains), so the whole then(|| { ... }) branch and write_iterator_after effectively do nothing. Consider removing this dead code (and/or replacing it with None / Default::default()), and update the comment since no rescheduling happens anymore.

        .then(|| {
            quote_spanned! {op_span=>
                // Reschedule the subgraph lazily to ensure replay on later ticks.
                
            }
        });
        let write_iterator_after = quote_spanned! {op_span=>
            #replay_code
        };

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.