Skip to content

add DynamicLighting attribute to Map#4

Merged
baughj merged 1 commit into
mainfrom
feature/map-dynamic-lighting
Apr 30, 2026
Merged

add DynamicLighting attribute to Map#4
baughj merged 1 commit into
mainfrom
feature/map-dynamic-lighting

Conversation

@Caeldeth
Copy link
Copy Markdown
Contributor

Summary

  • Add optional DynamicLighting boolean attribute to the Map element, defaulting to false
  • Mirrors the existing IsEnabled / AllowCasting attributes ([XmlAttribute] + [DefaultValue(false)])
  • One property added in src/Objects/Map.cs, one matching attribute added in src/XSD/Map.xsd

Test plan

  • dotnet build succeeds
  • Existing LoadDataContainsNoLoadErrors Map check still passes (catches any XSD/serialization regression)
  • Downstream consumer (server-side lighting logic) can read the flag once wired up

🤖 Generated with Claude Code

Boolean attribute, default false. Signals whether a map supports
dynamic lighting in the client.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.50%. Comparing base (f534651) to head (f01de57).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   60.50%   60.50%           
=======================================
  Files          40       40           
  Lines        1504     1504           
  Branches      351      351           
=======================================
  Hits          910      910           
  Misses        474      474           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@baughj baughj merged commit 9a0e4ad into main Apr 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants