Repository navigation
Phase 5: history, apps, app detail, bottom navigation - #7
Merged
Merged
Conversation
… ranking Pure Kotlin for Phase 5: MeasurementQuality HIGH/MEDIUM/LOW/UNKNOWN from the event counters and the calibration in force (thresholds in MeasurementConfig), history bars per day or month with per-day statistics from the first measured day, round chart axes (decimal steps for distance, clock steps for minutes), app ranking by distance or time with share and quality, the scroll share of time in app, and per-app day summaries plus the first measured day from Room. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…vigation Navigation Compose 2.9.8 with @serializable routes and a bottom bar Přehled / Historie / Aplikace / Nastavení. Historie: 7 / 30 days and 12 months in a custom Canvas bar chart with tap-to-read bars and per-day statistics. Aplikace: Dnes / 7 dní / 30 dní / Celkem, sort by distance or time, share and a quality word; time-only apps show "—" and "bez dat o scrollu". The detail shows the period, quality with its explanation and 30-day distance and time charts. Nastavení holds the service and usage-access status, Přesnost měření and, in debug builds, the developer screens that left Přehled. ADR-029. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Quality describes how an app reports scrolling, not a period: rated on today's handful of events it read "málo dat" every morning. The list and the detail now rate on the app's all-time counters. The "43,7 % · Kvalita …" subtitle is one format string instead of a concatenation, and the detail no longer reads the first measured day it never used. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Navigation honours explicit deep-link extras on any intent that starts the exported launcher activity: MainActivity now drops them, and the app-detail route only renders a well-formed package name (MEDIUM, UI spoofing). - Pace and the scroll share sum both sides only over days that have a time in app; the usage sync looks back at most 9 days, so "Celkem" mixed spans (MEDIUM). - Aplikace ranks only once the all-time counters are read (no quality flash); a bar-chart label cannot invert its range on a narrow plot; "Zpět" checks the top entry instead of RESUMED; one unit per distance axis; history statistics survive a first day after today; chart selection is keyed by date. - kotlinx-serialization-core instead of -json: routes need no JSON. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 — Historie + Aplikace (PLAN.md)
Scope: bottom navigation Přehled / Historie / Aplikace / Nastavení (Navigation Compose 2.9.8,
@Serializableroutes, D14); Historie 7 / 30 days / 12 months in a custom Canvas bar chart with per-day statistics; Aplikace Dnes / 7 dní / 30 dní / Celkem with sort by distance or time, share and a measurement-quality word; app detail with period totals, pace, scroll share and 30-day charts; minimal Nastavení (service, Usage access, Přesnost měření, debug tools moved here). ADR-029.DoD
MeasurementQuality, spec §20)Verification
testDebugUnitTest lintDebug assembleDebug assembleReleasegreen (lint: only the 6 oldSetTextI18nin the Phase 1 debug View surface), 25 tools tests, manifest policy OK for debug + release. No new permission, no new exported component.--es devtoolstill works./topshit(quality on all-time counters, localizable subtitle), Stage 2 security + functional (Fable): 2× MEDIUM (deep-link extras → UI spoofing; pace/share mixed spans) + 5× LOW + 1× INFO fixed in7fa5920.CI
GitHub Actions are still blocked by the account's billing / spending limit (open point in
handoff.md). The merge relies on the CI-equivalent gate run in a clean checkout of this branch (same commands as.github/workflows/ci.yml+assembleRelease, JDK 21).🤖 Generated with Claude Code