Repository navigation
Phase 2 — calibration: card calibration, accuracy screen, accuracy tooling - #4
Merged
Merged
Conversation
…engine - CalibrationRepository (DataStore Preferences) stores the card calibration and a calibrationVersion that counts every user change; implausible or incomplete values read as no calibration (ADR-024). - PhysicalScaleProvider.resolve: the card over xdpi/ydpi, only on the phone and panel resolution it was made on; the scale carries the version. - The service loads the stored calibration before converting the first sample and follows changes live; every MeasurementResult carries its calibrationVersion (spec §65). - New screens Kalibrace displeje (vertical bar in raw px, slider + 1 px steps, ADR-023) and Přesnost měření (spec §33), reachable from home. - Debug test list: runs form a series with MAE / MAPE on screen; TESTLIST line and debug CSV header carry the calibration in force. - tools/accuracy.py: ground truth CSV vs measured CSV -> MAE, MAPE; device_accuracy.py --csv-out writes that pair. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…en's limit Measured on the OnePlus CPH2399: the bar area allowed only 1219 px while the card needs ~1356 px. Title and instructions now sit beside the bar (the card covers them once placed) and the controls are compact — the area now allows ~1600 px. In landscape the bar could only reach ~400 px and a nonsense calibration (+222 %) could be saved. A bar pinned at the screen's limit cannot have matched a longer card: Save is disabled and the hint says to hold the phone upright. Debug logcat lines carry the calibration version (cv=) the distance used. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Back from Kalibrace displeje returns to where it was opened (home or Přesnost); only a save or "use the automatic estimate" lands on Přesnost. - Save / skip act once: a double tap bumped the calibration version twice (verified on the test phone: v2 -> v3 after a double tap). - The instruction text scrolls when the bar area is short (landscape). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 933d342a2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+75
to
+77
| scope.launch { | ||
| change() | ||
| onSaved() |
There was a problem hiding this comment.
If DataStore.edit fails—for example because storage is full or an I/O error occurs—change() throws from this launch, so onSaved() is never called and committing remains true; the uncaught coroutine exception may also terminate the app. This affects both saving a card and selecting the automatic estimate. Catch the failure, re-enable the controls, and report it so the user can retry.
Useful? React with 👍 / 👎.
…one, what remains The continue prompt now resumes an in-progress phase on its existing branch instead of starting a new one from main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…app" Honza (2026-09-24): keep developing, decide autonomously, finish the whole app. Manual on-phone checks move to "Dluh ověření" in handoff.md (V1 Instagram/TikTok, V2 card calibration, V3 MAPE with the card); the continue prompt merges each phase after its gates and uses an emulator instead of Honza's phone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 per
PLAN.md— the most accurate px → mm scale available, with its method and confidence stored.What is in it
CalibrationRepository(DataStore Preferences): card calibration +calibrationVersion(counts the user's changes). Implausible or incomplete values read as "no card" (ADR-024).PhysicalScaleProvider.resolve: card (HIGH) overxdpi/ydpi(MEDIUM) — the card only on the phone and panel resolution it was made on.MeasurementResultcarries its calibration version, nothing is recomputed (spec §65).TESTLISTline and debug CSV header carry the calibration in force.tools/accuracy.py(ground truth CSV vs measured CSV → MAE, MAPE);device_accuracy.py --csv-out.measurement-model.md,architecture.md,accuracy-testing.md, README updated.Definition of Done (PLAN Phase 2)
cv=1xdpi/ydpi; card from another resolution →xdpi/ydpi(unit test); "Přeskočit – použít automatický odhad" switched the running service live (cv=2, 25.4 / ydpi, no reconnect)Reviews
/topshit7/10 over the cumulative diff — 3 findings fixed and verified on the phoneTests
🤖 Generated with Claude Code