feat(agents): hover details on tick beats + arrow-key navigation between snapshots by cardosofede · Pull Request #267 · hummingbot/condor

cardosofede · 2026-10-03T06:32:54Z

Summary

Two review-ergonomics improvements to the agent run screen:

Tick strip hover card — hovering (or keyboard-focusing) a beat in the tick strip now opens a card with:

tick number, timestamp and state (Actions ran / Action failed / No actions / Not logged)
the journal's summary line
every deed with ✓/✗ and its error text (capped at 6, "+N more")

The card is portalled and fixed-positioned so the strip's horizontal scroller can't clip it, and it clamps/flips to stay in the viewport. Replaces the native title tooltip (kept as aria-label).

Arrow keys between snapshots — the tick overlay now has ‹ › buttons, an N/M position counter, and ←/→ keyboard navigation through the session's ticks.

Steps follow journal order (skips gaps in numbering), disabled at either end
Ignored while typing in inputs or with modifier keys held
Steps replace history, so Back still closes the overlay in one press (WorkspaceUrlAdapter.set gained an optional { replace } override)
Neighbouring snapshots are prefetched so a step renders instantly

Test plan

New tests: TickSpine.test.tsx (hover card content, deed cap, pre-log ticks, focus), TickOverlay.test.tsx (adjacentTicks, arrows, modifiers/inputs, buttons, close)
Full frontend suite: 2273 passed; tsc -b, lint:ci, build green
Verified live on brigado / PMM King BTC-BRL S5 (55 ticks): card renders on failed and edge beats, arrows step the overlay, Back closes it

🤖 Generated with Claude Code

…hots - TickSpine: hovering or focusing a beat opens a portalled card with the tick's time, state, journal line and every deed (errors in red), capped at 6 with '+N more'. Replaces the native title tooltip. - TickOverlay: the tick view gets prev/next buttons, an N/M counter and ArrowLeft/ArrowRight navigation (ignored while typing or with modifiers). Steps replace history so Back still closes the overlay in one press, and neighbouring snapshots are prefetched. - WorkspaceUrlAdapter.set takes an optional { replace } override.

greptile-apps · 2026-10-03T06:35:38Z

Confidence Score: 4/5

[Medium risk] Adds hover cards and keyboard navigation to tick timeline.

The PR is not yet safe to merge because navigation can still lead to a journal tick without a snapshot.

Findings

Journal ticks can lack snapshots ▶
Keyboard focus becomes invisible ▶
Ring overlaps another tick ▶
Focused card covers snapshot ▶
Tall cards can leave viewport ▶
Gap clicks do nothing ▶
Focused card disappears ▶

Summary

The PR adds tick detail cards and snapshot navigation with adjacent prefetching and history replacement. Since the previous review, it changes the tick strip to animate visuals inside fixed hit targets and adds pointer handling for wrapped rows. Two new interaction mismatches remain in the strip.

_{Reviews (5) · Last reviewed commit: "Merge pull request #269 from mlguys/feat..."}

greptile-apps · 2026-10-03T06:35:45Z

+  const ticks = useMemo(
+    () =>
+      journalContent ? parseJournal(journalContent).ticks.map((t) => t.tick) : [],
+    [journalContent],
+  );
+  const { prev, next, index } = adjacentTicks(ticks, tick);


Journal ticks can lack snapshots

When a run is blocked, the engine records a journal tick but does not write a snapshot. Arrow navigation includes that tick anyway. Selecting it makes the snapshot request return 404, so the overlay shows “Select a snapshot to view details” instead of a snapshot. Navigation should use ticks with available snapshots or explain journal-only ticks.

Knowledge Base Used: Frontend application

greptile-apps · 2026-10-03T06:35:45Z

            onClick={() => onSelectTick(entry.tick)}
+            onMouseEnter={(e) => showCard(entry.tick, e.currentTarget)}
+            onMouseLeave={hideCard}
+            onFocus={(e) => showCard(entry.tick, e.currentTarget)}
+            onBlur={hideCard}


Focused card covers snapshot

Selecting a keyboard-focused beat does not blur it, so its hover card stays open when the tick overlay appears. The card has a higher z-index than the overlay and can cover part of the snapshot until focus moves elsewhere. Dismiss the card when the beat is selected or the overlay opens.

greptile-apps · 2026-10-03T06:35:45Z

+  const above = vh - anchor.bottom < CARD_MIN_ROOM && anchor.top > vh - anchor.bottom;
+  const position = above
+    ? { left, bottom: vh - anchor.top + CARD_GAP }
+    : { left, top: anchor.bottom + CARD_GAP };


Tall cards can leave viewport

The card flips above a beat only when less than 240 pixels remain below it, but six deeds with summaries and error text can make the card much taller. On a short viewport, it can open below the beat and clip the details. Use the card’s measured height for placement or constrain its height and allow scrolling.

The beat under the pointer (or focus) scales to 2x width and 1.2x height, covering the gaps beside it. A transform rather than a width change, so neighbours do not reflow under the cursor.

Each beat is now a fixed 16px button with the bar drawn inside it, so the targets sit edge to edge while the bars get an 8px gap. Hovering grows only the inner bar and gives it a 2px contour (the selected beat keeps its primary ring), without reflowing the neighbours.

The hovered beat's real width and height animate (8x20 -> 14x26, 200ms ease-out), so its neighbours slide over and the 8px gap stays fixed, instead of a fixed slot with the bar growing inside it. Hover is tracked on the strip: a pointer in a gap keeps the nearest beat, so sliding along the row never flickers. Respects prefers-reduced-motion.

greptile-apps · 2026-10-03T09:39:54Z

      }
-      className={`flex items-center gap-1 ${
-        // The vertical padding is room for the selected beat's ring, which an
+      className={`flex items-center gap-2 ${


Gap clicks do nothing

The pointer tracker shows the nearest beat’s card while the pointer is in the new 8px gap, but only the beat buttons handle clicks. Clicking where the card says “Click to open this tick” therefore does nothing. Keep the clickable targets contiguous or make a gap click select the beat shown on the card.

greptile-apps · 2026-10-03T09:39:54Z

      ref={stripRef}
      data-testid="tick-spine"
+      onPointerMove={trackPointer}
+      onPointerLeave={hideCard}


Focused card disappears

When a beat has keyboard focus, leaving the strip with the pointer clears its card. The beat remains focused, so onFocus does not fire again and its details stay unavailable until focus moves away and back. Preserve the focused beat’s card when pointer hover ends.

mlguys · 2026-10-03T10:31:45Z

Hey @cardosofede, I added a fix for hovering effect to make it better here #269

fix/Improve tick hovering

mlguys · 2026-10-03T11:11:53Z

LGTM!

greptile-apps · 2026-10-03T11:14:09Z

+            onBlur={hideCard}
+            data-beat-hovered={isHovered || undefined}
+            data-beat-selected={isSelected || undefined}
+            className="relative h-5 w-2 shrink-0 rounded-sm outline-none"


Keyboard focus becomes invisible

When a beat has keyboard focus, moving the pointer to another beat or out of the strip moves or clears its visible ring. The focused button also has outline-none, so users can no longer see which beat Enter will open.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-10-03T11:14:09Z

+        const offset = hoveredIndex < 0 || index === hoveredIndex
+          ? 0
+          : index < hoveredIndex ? -3 : 3;


Ring overlaps another tick

When a selected beat sits next to the hovered beat, the new offset can move its ring over the preceding beat’s fixed button. Clicking that visible part of the selected ring opens the preceding tick instead, making the strip misleading to use.

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

cardosofede requested a review from mlguys October 3, 2026 06:47

cardosofede added 2 commits October 3, 2026 14:18

feat(agents): hovered tick beat grows so it is harder to slip off

efe3f27

The beat under the pointer (or focus) scales to 2x width and 1.2x height, covering the gaps beside it. A transform rather than a width change, so neighbours do not reflow under the cursor.

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread frontend/src/components/agent/lab/TickSpine.tsx Outdated

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

fix tick hovering

af3ec33

Merge pull request #269 from mlguys/feat/improve-hover

6b3f707

fix/Improve tick hovering

mlguys approved these changes Oct 3, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

Navigation Menu

feat(agents): hover details on tick beats + arrow-key navigation between snapshots - #267

feat(agents): hover details on tick beats + arrow-key navigation between snapshots#267
cardosofede wants to merge 6 commits into
mainfrom
feat/agent-review-ux

cardosofede commented Oct 3, 2026

Uh oh!

greptile-apps Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

mlguys commented Oct 3, 2026

Uh oh!

mlguys commented Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cardosofede commented Oct 3, 2026

Summary

Test plan

Uh oh!

greptile-apps Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

mlguys commented Oct 3, 2026

Uh oh!

mlguys commented Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Oct 3, 2026 •

edited

Loading