fix/Show an LP executor's earned fees in its detail view instead of the transaction fee

[lgrawet]

Show an LP executor's earned fees in its detail view instead of the transaction fee fee: the connector fills cum_fees_quote with what the open and close cost on-chain and puts the fee income in custom_info.fees_earned_quote, so the one number that says whether a band is worth keeping read three orders of magnitude low — a live DJT-USDC band showed $0.000023 against $0.074624 actually earned; the formatter now prefers fees_earned_quote when the executor carries it and falls back to cum_fees_quote for executors that have no custom_info twin

[greptile-apps]

Confidence Score: 4/5

[Medium risk] Changes which fee metric displays for liquidity pool executors.

The PR is not safe to merge until the detail view recognizes LP executors whose type is in config.

Findings

1.  Nested LP type is missed ▶

Summary

The PR changes executor detail output to show LP fee income separately from fees paid by other executors and adds formatter tests. The new type check does not cover LP payloads whose type is nested in config.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Raw executor detail] --> B{Top-level type is lp_executor?}
  B -- Yes --> C[Show custom_info fees_earned_quote]
  B -- No --> D[Show cum_fees_quote as Fees Paid]
  E[LP with config.type only] --> B

Loading

_{Reviews (3) · Last reviewed commit: "Merge remote-tracking branch 'upstream/m..."}

[greptile-apps]

Nested LP type is missed

If an LP executor stores its type in config.type, this check reads only top-level fields and treats it as a non-LP executor. The detail view then hides its earned fees and shows its on-chain transaction cost as “Fees Paid.” Resolve the type from the config too, and test that payload shape.