[v1.19] Update for HumHub 1.19

.github/workflows/codeception-min-version.yml

@@ -13,3 +13,4 @@ jobs:
     with:
       module-id: mail
       use-rest-module: true
+      rest-module-branch: develop

Events.php

@@ -9,6 +9,7 @@
 namespace humhub\modules\mail;
 
 use humhub\commands\IntegrityController;
+use humhub\helpers\ControllerHelper;
 use humhub\modules\mail\helpers\Url;
 use humhub\modules\mail\models\Config;
 use humhub\modules\mail\models\Message;
@@ -22,6 +23,7 @@
 use humhub\modules\ui\menu\MenuLink;
 use humhub\modules\user\widgets\HeaderControlsMenu;
 use humhub\widgets\MetaSearchWidget;
+use humhub\widgets\TopMenu;
 use Yii;
 
 /**
@@ -152,20 +154,23 @@ public static function onUserDelete($event)
     public static function onTopMenuInit($event)
     {
         try {
-            if (Yii::$app->user->isGuest) {
+            if (Yii::$app->user->isGuest || !Yii::$app->user->impersonation->canAccessPrivateContent()) {
                 return;
             }
 
+            /* @var TopMenu $menu */
+            $menu = $event->sender;
+
             $module = Config::getModule();
             // See https://github.com/humhub/humhub-modules-mail/issues/201
             if (method_exists($module, 'hideInTopNav') && !$module->hideInTopNav()) {
-                $event->sender->addItem([
+                $menu->addEntry(new MenuLink([
                     'label' => Yii::t('MailModule.base', 'Messages'),
                     'url' => Url::toMessenger(),
-                    'icon' => '<i class="fa fa-envelope"></i>',
-                    'isActive' => (Yii::$app->controller->module && Yii::$app->controller->module->id == 'mail'),
+                    'icon' => 'envelope',
+                    'isActive' => ControllerHelper::isActivePath('mail'),
                     'sortOrder' => 300,
-                ]);
+                ]));
             }
         } catch (\Throwable $e) {
             Yii::error($e);
@@ -175,23 +180,40 @@ public static function onTopMenuInit($event)
     public static function onNotificationAddonInit($event)
     {
         try {
-            if (Yii::$app->user->isGuest) {
+            if (Yii::$app->user->isGuest || !Yii::$app->user->impersonation->canAccessPrivateContent()) {
                 return;
             }
 
-            $event->sender->addWidget(NotificationInbox::className(), [], ['sortOrder' => 90]);
+            $event->sender->addWidget(NotificationInbox::class, [], ['sortOrder' => 90]);
         } catch (\Throwable $e) {
             Yii::error($e);
         }
     }
 
+    /**
+     * Adds the number of unseen conversation messages to the push notification
+     * badge count of the `fcm-push` module.
+     *
+     * @param \humhub\modules\fcmPush\events\NotificationCountEvent $event
+     */
+    public static function onPushNotificationCount($event)
+    {
+        try {
+            $event->count += (int)UserMessage::getNewMessageCount($event->user->id);
+        } catch (\Throwable $e) {
+            Yii::error('Messenger - Error onPushNotificationCount: ' . $e);
+        }
+    }
+
     public static function onProfileHeaderControlsMenuInit($event)
     {
         try {
             /* @var HeaderControlsMenu $menu */
             $menu = $event->sender;
 
-            if ($menu->user->isCurrentUser() || !Yii::$app->user->can(StartConversation::class)) {
+            if ($menu->user->isCurrentUser()
+                || !Yii::$app->user->impersonation->canAccessPrivateContent()
+                || !Yii::$app->user->can(StartConversation::class)) {
                 return;
             }
 
@@ -244,7 +266,7 @@ public static function onRestApiAddRules()
 
     public static function onMetaSearchWidgetInit($event)
     {
-        if (Yii::$app->user->isGuest) {
+        if (Yii::$app->user->isGuest || !Yii::$app->user->impersonation->canAccessPrivateContent()) {
             return;
         }
 

Module.php

@@ -2,7 +2,6 @@
 
 namespace humhub\modules\mail;
 
-use humhub\components\console\Application as ConsoleApplication;
 use humhub\modules\mail\models\MessageEntry;
 use humhub\modules\mail\notifications\MailNotification;
 use humhub\modules\mail\notifications\ConversationNotification;
@@ -40,19 +39,6 @@ class Module extends \humhub\components\Module
      */
     public $conversationUpdatePageSize = 50;
 
-    /**
-     * @inheritdoc
-     */
-    public function init()
-    {
-        parent::init();
-
-        if (Yii::$app instanceof ConsoleApplication) {
-            // Prevents the Yii HelpCommand from crawling all web controllers and possibly throwing errors at REST endpoints if the REST module is not available.
-            $this->controllerNamespace = 'mail/commands';
-        }
-    }
-
     /**
      * @return static
      */

config.php

@@ -18,5 +18,6 @@
         ['class' => IntegrityController::class, 'event' => IntegrityController::EVENT_ON_RUN, 'callback' => ['humhub\modules\mail\Events', 'onIntegrityCheck']],
         ['class' => 'humhub\modules\rest\Module', 'event' => 'restApiAddRules', 'callback' => ['humhub\modules\mail\Events', 'onRestApiAddRules']],
         ['class' => 'humhub\widgets\MetaSearchWidget', 'event' => 'init', 'callback' => ['humhub\modules\mail\Events', 'onMetaSearchWidgetInit']],
+        ['class' => 'humhub\modules\fcmPush\services\MessagingService', 'event' => 'pushNotificationCount', 'callback' => ['humhub\modules\mail\Events', 'onPushNotificationCount']], // humhub\modules\fcmPush\services\MessagingService::EVENT_NOTIFICATION_COUNT
     ],
 ];

controllers/ConfigController.php

@@ -8,9 +8,8 @@
 
 namespace humhub\modules\mail\controllers;
 
-use Yii;
 use humhub\modules\mail\models\Config;
-use humhub\models\Setting;
+use Yii;
 
 /**
  * ConfigController handles the configuration requests.

controllers/InboxController.php

@@ -24,6 +24,7 @@ protected function getAccessRules()
     {
         return [
             [ControllerAccess::RULE_LOGGED_IN_ONLY],
+            [ControllerAccess::RULE_DENY_IMPERSONATED],
         ];
     }
 

controllers/MailController.php

@@ -53,6 +53,7 @@ protected function getAccessRules()
     {
         return [
             [ControllerAccess::RULE_LOGGED_IN_ONLY],
+            [ControllerAccess::RULE_DENY_IMPERSONATED],
             [ControllerAccess::RULE_PERMISSION => StartConversation::class, 'actions' => ['create', 'add-user']],
         ];
     }
@@ -308,7 +309,7 @@ private function findUserByFilter($keyword, $maxResult)
                 $userInfo = [];
                 $userInfo['guid'] = $user->guid;
                 $userInfo['displayName'] = Html::encode($user->displayName);
-                $userInfo['image'] = $user->getProfileImage()->getUrl();
+                $userInfo['image'] = $user->image->getUrl();
                 $userInfo['link'] = $user->getUrl();
                 $results[] = $userInfo;
             }

controllers/TagController.php

@@ -31,6 +31,7 @@ protected function getAccessRules()
     {
         return [
             [ControllerAccess::RULE_LOGGED_IN_ONLY],
+            [ControllerAccess::RULE_DENY_IMPERSONATED],
         ];
     }
 

docs/CHANGELOG.md

@@ -1,6 +1,32 @@
 Changelog
 =========
 
+3.4.5 (Unreleased)
+------------------
+- Enh #510: Deny access to the Messenger while an admin impersonates a user, since conversations are private content — requires core 1.19 and can be disabled with the core `\humhub\modules\user\components\Impersonation::$allowPrivateContentAccess` option (humhub/humhub#8372)
+
+3.4.4 (July 31, 2026)
+---------------------
+- Fix #509: "Write a message" too low on Android Chrome based browsers
+
+3.4.3 (July 21, 2026)
+---------------------
+- Enh #506: Add the number of unseen conversation messages to the push notification badge count (requires `fcm-push` 2.2.9+)
+- Enh #507: Trigger the new core `UnreadCountChangedEvent` when a conversation is marked as seen/unread or replied to, so the push notification badge count is refreshed (requires `fcm-push` 2.2.9+)
+
+3.4.2 (July 8, 2026)
+--------------------
+- Fix #499: Update user image
+- Enh #500: Add aria-label attribute for icon-only buttons
+
+3.4.1 (June 22, 2026)
+---------------------
+- Fix #498: Fix use of removed module property `isActivated`
+
+3.4.0 (June 5, 2026)
+--------------------
+- Enh #483: Update for HumHub 1.19
+
 3.3.12 (July 16, 2026)
 ----------------------
 - Fix #504: Message entries overflow horizontally on iOS Safari

messages/am/base.php

@@ -4,13 +4,13 @@
     'Cancel' => 'ይቅር',
     'Confirm' => 'አረጋግጥ',
     'Delete' => 'አስወግድ',
+    'Disabled' => 'የማይሰራ',
     'Edit' => 'ማስተካከያ',
     'Filter' => 'አጣራ',
     'Message' => 'መልዕክት',
     'Pinned' => 'የተሰካ',
     'Search' => 'ፈልግ',
     'Subject' => 'ርዕስ',
-    'Title' => 'ርዕስ',
     'Unpin' => 'ንቀል',
     'User' => 'ተጠቃሚ',
     '<strong>Confirm</strong> deleting conversation' => '',
@@ -37,13 +37,14 @@
     'Created At' => '',
     'Created By' => '',
     'Delete conversation' => '',
-    'Disabled' => '',
     'Do you really want to delete this conversation?' => '',
     'Do you really want to delete this message?' => '',
     'Do you really want to delete this tag?' => '',
     'Do you really want to leave this conversation?' => '',
+    'Edit conversation subject' => '',
     'Edit message entry' => '',
     'Edit message...' => '',
+    'Edit subject' => '',
     'Friday' => '',
     'Here you can manage your private conversation tags.' => '',
     'Is Originator' => '',
@@ -69,6 +70,7 @@
     'Receive Notifications when someone sends you a message.' => '',
     'Receive private messages' => '',
     'Recipient' => '',
+    'Reply' => '',
     'Reply now' => '',
     'Required' => '',
     'Saturday' => '',

messages/an/base.php

@@ -22,7 +22,6 @@
     'Subject' => 'Asunto',
     'Tags' => 'Etiquetas',
     'There are no messages yet.' => 'Encara no i hai mensaches',
-    'Title' => 'Títol',
     'Unpin' => 'Des-fixar',
     'Updated At' => 'Actualizau o',
     'Updated By' => 'Actualizau per',
@@ -53,7 +52,9 @@
     'Do you really want to delete this message?' => '',
     'Do you really want to delete this tag?' => '',
     'Do you really want to leave this conversation?' => '',
+    'Edit conversation subject' => '',
     'Edit message...' => '',
+    'Edit subject' => '',
     'Friday' => '',
     'Here you can manage your private conversation tags.' => '',
     'Is Originator' => '',
@@ -77,6 +78,7 @@
     'Receive Notifications when someone opens a new conversation.' => '',
     'Receive Notifications when someone sends you a message.' => '',
     'Receive private messages' => '',
+    'Reply' => '',
     'Reply now' => '',
     'Required' => '',
     'Saturday' => '',

messages/ar/base.php

@@ -11,6 +11,7 @@
     'Created At' => 'أنشئت في',
     'Created By' => 'تم وضعه بواسطة',
     'Delete' => 'حذف',
+    'Disabled' => 'غير مفعل',
     'Do you really want to delete this conversation?' => 'هل تريد حذف هذه المحادثة؟',
     'Do you really want to delete this message?' => 'هل تريد حذف هذه الرسالة؟',
     'Do you really want to leave this conversation?' => 'هل تريد مغادرة هذه المحادثة؟',
@@ -23,10 +24,13 @@
     'Messages' => 'الرسائل',
     'Monday' => 'الاثنين',
     'New message from {senderName}' => 'رسالة جديدة من {senderName}',
+    'Optional' => 'اختياري',
     'Participants' => 'المشاركون',
     'Pinned' => 'تثبيت',
     'Recipient' => 'المستلم',
+    'Reply' => 'رد',
     'Reply now' => 'اضف رد',
+    'Required' => 'مطلوب',
     'Saturday' => 'السبت',
     'Search' => 'بحث',
     'Send' => 'ارسال',
@@ -37,7 +41,6 @@
     'Tags' => 'الأوسمة',
     'There are no messages yet.' => 'لا توجد رسائل',
     'Thursday' => 'الخميس',
-    'Title' => 'العنوان',
     'Today' => 'اليوم',
     'Tuesday' => 'الثلاثاء',
     'Unpin' => 'إلغاء التثبيت',
@@ -63,9 +66,10 @@
     'Conversation tags can be used to filter conversations and are only visible to you.' => '',
     'Conversations' => '',
     'Delete conversation' => '',
-    'Disabled' => '',
     'Do you really want to delete this tag?' => '',
+    'Edit conversation subject' => '',
     'Edit message...' => '',
+    'Edit subject' => '',
     'Here you can manage your private conversation tags.' => '',
     'Is Originator' => '',
     'Last Viewed' => '',
@@ -79,12 +83,10 @@
     'Max number of new conversations allowed for a user per day' => '',
     'My Tags' => '',
     'New conversation from {senderName}' => '',
-    'Optional' => '',
     'Pin' => '',
     'Receive Notifications when someone opens a new conversation.' => '',
     'Receive Notifications when someone sends you a message.' => '',
     'Receive private messages' => '',
-    'Required' => '',
     'Seperate restrictions for new users' => '',
     'Show menu item in top Navigation' => '',
     'Start new conversations' => '',

messages/bg/base.php

@@ -25,6 +25,7 @@
     'Created By' => 'Създадено от',
     'Delete' => 'Изтрий',
     'Delete conversation' => 'Изтрий обсъждането',
+    'Disabled' => 'Деактивиран',
     'Do you really want to delete this conversation?' => 'Наистина ли искаш да изтриеш обсъждането?',
     'Do you really want to delete this message?' => 'Наистина ли искаш да изтриеш съобщението?',
     'Do you really want to delete this tag?' => 'Наистина ли искаш да изтриеш този етикет?',
@@ -50,13 +51,16 @@
     'Monday' => 'Понеделник',
     'My Tags' => 'Моите етикети',
     'New message from {senderName}' => 'Ново съобщение от {senderName}',
+    'Optional' => 'По желание',
     'Participants' => 'Участници',
     'Pinned' => 'Фиксирано',
     'Receive Notifications when someone opens a new conversation.' => 'Получи съобщение, когато някой отвори ново обсъждане.',
     'Receive Notifications when someone sends you a message.' => 'Получи съобщение, когато някой ти изпрати съобщение.',
     'Receive private messages' => 'Получавай лични съобщения',
     'Recipient' => 'Получател',
+    'Reply' => 'Отговор',
     'Reply now' => 'Отговори сега',
+    'Required' => 'Задължително',
     'Saturday' => 'Събота',
     'Search' => 'Търси',
     'Send' => 'Изпрати',
@@ -71,7 +75,6 @@
     'There are no messages yet.' => 'Все още нямате съобщения.',
     'This user is already participating in this conversation.' => 'Този потребител вече присъства в обсъждането.',
     'Thursday' => 'Четвъртък',
-    'Title' => 'Заглавие',
     'Today' => 'Днес',
     'Tuesday' => 'Вторник',
     'Unpin' => 'Освободи',
@@ -93,12 +96,11 @@
     '<strong>Messenger</strong> module configuration' => '',
     '<strong>New</strong> conversation' => '',
     'Advanced Messages Search' => '',
-    'Disabled' => '',
+    'Edit conversation subject' => '',
+    'Edit subject' => '',
     'Mark Unread' => '',
     'New conversation from {senderName}' => '',
-    'Optional' => '',
     'Pin' => '',
-    'Required' => '',
     'Yesterday' => '',
     'You are not allowed to participate in this conversation. You have been blocked by: {userNames}.' => '',
     'You are not allowed to reply to users {userNames}!' => '',