Fix TopMenu compatibility with HumHub v1.19 - #41
Merged
Conversation
addItem() was removed in HumHub v1.20 (deprecated since v1.4). addEntry() with MenuLink is available since v1.4 and works across v1.18, v1.19, and v1.20.
luke-
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addItem()call withaddEntry(new MenuLink([...]))inonTopMenuInitaddItem()was removed in HumHub v1.19 (deprecated since v1.4), causing anUnknownMethodExceptionon installs running v1.19addEntry()is available since v1.4, so the fix is fully backward-compatible with v1.18Reviewed for other v1.19 removals: The module's other usages of core APIs (
BaseNotification,bootstrap\Button,LayoutAddons,ActiveForm) are all unaffected — none of the removed methods or constants are used.Test plan
UnknownMethodExceptionis gone, top menu entries appear