Bundle Twemoji SVG flags and add admin Teams view - #37
Merged
Conversation
…s from shared flag codepoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two complementary changes:
Bundled Twemoji SVG flags
National flags no longer depend on the platform's emoji font — they are rendered from SVGs bundled with the module. Fixes flags showing as invisible on Chrome/Linux (regional-indicator pairs unsupported by common system fonts) and inconsistent emoji styles across browsers.
resources/flags/, served via the existing asset bundle — no CDN involved.TeamNameLocalizer::flagCodepoints()API from Fix flag and name resolution for non-ISO FIFA members (England, Scotland, Wales, Kosovo) #33: the codepoint sequence doubles as the SVG filename, so emoji semantics and asset lookup share one source.resources/flags/LICENSE(attribution notice) andLICENSE-GRAPHICS(full CC BY 4.0 text as supplied by the licensor) are included.ENG, new ScotlandSCOreplacing Morocco), so the subdivision flags are exercised by test competitions.Admin Teams view
The competition admin view gains a "Teams" page (analogous to Special bets) listing all participating teams with their flag, name and group — reachable via a "Teams (N)" button. It renders through the shared
_team_badge.phppartial, so it shows the bundled SVG flags introduced above.