- Fix: Open the notification URL when a notification is clicked while… - #99
Open
marc-farre wants to merge 2 commits into
Open
- Fix: Open the notification URL when a notification is clicked while…#99marc-farre wants to merge 2 commits into
marc-farre wants to merge 2 commits into
Conversation
… the app is already open — Firebase only focuses the window without navigating, and iOS PWAs never dispatch the click event to the service worker at all humhub/humhub-internal#1263
lisandi
pushed a commit
to T3Social/fcm-push
that referenced
this pull request
Aug 17, 2026
Firebase's own notificationclick handler only focuses an already-open window without navigating it. Register our own handler before Firebase's importScripts that focuses and navigates (or opens a new window). Deterministic subset of PR humhub#99 by Marc Farré, without the page-side heuristic for iOS PWAs that are already running (WebKit never dispatches notificationclick there).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the app is already open — Firebase only focuses the window without navigating, and iOS PWAs never dispatch the click event to the service worker at all
https://github.com/humhub/humhub-internal/issues/1263