Skip to content

Fix param type on process message #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yurabakhtin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix param type on process message #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/MessagingService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ public function processNotification(BaseNotification $baseNotification, User $us
);
}

public function processMessage(User $user, string $title, string $body, ?string $url, ?string $imageUrl, ?int $notificationCount)
public function processMessage(User $user, ?string $title, ?string $body, ?string $url, ?string $imageUrl, ?int $notificationCount)

@luke- luke- May 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurabakhtin Is it really a good idea to allow notifications without any text?

@yurabakhtin yurabakhtin May 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luke- I don't know why the error exists at all because the params cannot be null:

@luke- luke- May 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurabakhtin That's really strange. Maybe html_entity_decode returns null? In any case, I would not recommend the current PR but rather look for the cause.

{
foreach ($this->drivers as $driver) {
$tokens = (new TokenService())->getTokensForUser($user, $driver);
if (empty($tokens)) {
continue;
}

$driver->processCloudMessage($tokens, $title, $body, $url, $imageUrl, $notificationCount);
$driver->processCloudMessage($tokens, (string) $title, (string) $body, $url, $imageUrl, $notificationCount);
}
}

Expand Down