Skip to content

Fix: Missing icon in Context Menu (File handler) and wrong styling in… #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke- merged 2 commits into from
Oct 6, 2025
Merged

Fix: Missing icon in Context Menu (File handler) and wrong styling in… #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ed0a99
Fix: Missing icon in Context Menu (File handler) and wrong styling in…
marc-farre Oct 6, 2025
d6bf8c3
Add PR ID to CHANGELOG
marc-farre Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
0.17.1 - (Unreleased)
------------------------
- Enh #255: Improved Module Test GitHub Actions
- Fix #256: Missing icon in Context Menu (File handler) and wrong styling in files context menu

0.17.0 - August 29, 2025
------------------------
Expand Down
11 changes: 7 additions & 4 deletions models/ZipImportHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,25 @@

namespace humhub\modules\cfiles\models;

use Yii;
use humhub\modules\file\handler\BaseFileHandler;
use humhub\modules\ui\icon\widgets\Icon;
use Yii;

class ZipImportHandler extends BaseFileHandler
{
public string $icon = 'file-archive-o';

/**
* The file handler link
*
* @see \yii\helpers\Html::renderTagAttributes() for details on how attributes are being rendered.
* @see \humhub\modules\file\widgets\FileHandlerButtonDropdown
* @return array the HTML attributes of the button.
* @see \humhub\modules\file\widgets\FileHandlerButtonDropdown
* @see \yii\helpers\Html::renderTagAttributes() for details on how attributes are being rendered.
*/
public function getLinkAttributes()
{
return [
'label' => Yii::t('CfilesModule.base', 'Import Zip'),
'label' => Icon::get($this->icon) . Yii::t('CfilesModule.base', 'Import Zip'),
'data-action-click' => 'file.upload',
'data-action-target' => '#cfilesUploadZipFile',
];
Expand Down
5 changes: 4 additions & 1 deletion widgets/FileListContextMenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,10 @@ private function addMenu(string $label, string $action, string $icon, int $sortO
'url' => '#',
'icon' => $icon,
'sortOrder' => $sortOrder,
'htmlOptions' => ['data-action' => $action],
'htmlOptions' => [
'data-action' => $action,
'class' => 'link dropdown-item',
],
]));
}

Expand Down