Skip to content

Fix CLI help for --rpc-url parameter #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quasiyoke merged 1 commit into from
Mar 24, 2025
Merged

Fix CLI help for --rpc-url parameter #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/humanode-peer/src/cli/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub struct BioauthFlowParams {
pub webapp_url: Option<String>,

/// The URL to pass to the web app to connect to the node RPC.
/// If not passed, a URL with `localhost` and the HTTP RPC port will be used.
/// If not passed, a URL with WebSocket scheme and `localhost` path will be used.
#[arg(long, value_name = "RPC_URL", conflicts_with_all = &["rpc_url_scheme_preference", "rpc_url_ngrok_detect", "rpc_url_unset"])]
pub rpc_url: Option<String>,

Expand Down
2 changes: 1 addition & 1 deletion utils/e2e-tests/bash/fixtures/help-output/help.bioauth.auth-url.stdout.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ Options:
The URL to use for the web app. Used to print the QR Code to the console, so it doesn't matter much

--rpc-url <RPC_URL>
The URL to pass to the web app to connect to the node RPC. If not passed, a URL with `localhost` and the HTTP RPC port will be used
The URL to pass to the web app to connect to the node RPC. If not passed, a URL with WebSocket scheme and `localhost` path will be used

--rpc-url-scheme-preference <RPC_URL_SCHEME_PREFERENCE>
What RPC URL scheme to prefer
Expand Down
2 changes: 1 addition & 1 deletion utils/e2e-tests/bash/fixtures/help-output/help.stdout.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ Options:
The URL to use for the web app. Used to print the QR Code to the console, so it doesn't matter much

--rpc-url <RPC_URL>
The URL to pass to the web app to connect to the node RPC. If not passed, a URL with `localhost` and the HTTP RPC port will be used
The URL to pass to the web app to connect to the node RPC. If not passed, a URL with WebSocket scheme and `localhost` path will be used

--rpc-url-scheme-preference <RPC_URL_SCHEME_PREFERENCE>
What RPC URL scheme to prefer
Expand Down