fix(humanize1): gen-plan stops while a decision is still PENDING - #9
Open
DongyunZou wants to merge 1 commit into
Open
fix(humanize1): gen-plan stops while a decision is still PENDING#9DongyunZou wants to merge 1 commit into
DongyunZou wants to merge 1 commit into
Conversation
rlcr never blocks on a person -- the quiz is advisory and --yolo answers the rest -- so a plan handed on with `## Pending User Decisions` entries still `PENDING` does not stop the loop, it idles it: every task hanging on a decision is deferred, round after round, and a week of reviews builds nothing. The gate is gen-plan's, at the end of the final consolidation: the finished plan is read for entries whose `Decision Status` still says `PENDING`, and the run stops with their DEC names rather than finish. The plan stays on disk with every position written down; deciding is all that is left to do. The template's own unfilled status line counts, since a status nobody touched is a decision nobody made. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gen-plannow refuses to finish while the final plan's## Pending User Decisionssection still holds aDecision Status: PENDINGentry. The run stops with aValueErrornaming theDEC-Nitems; the plan stays on disk with every position (planner's, reviewer's, the tradeoff) written down, so answering the statuses in the file -- or rerunning gen-plan with somebody at the prompt -- is all that is left to do.Why
rlcrnever blocks on a person by design: the plan-understanding quiz is advisory, and--yolo(--skip-quiz+--claude-answer-codex) answers the rest. So a plan handed on undecided does not stop the loop -- it idles it: the builder defers every task hanging on aPENDINGdecision, the reviewer counts each deferral incomplete, and a multi-day run burns its rounds building none of the mainline. Observed in practice as a loop where every major project stayed untouched.The gate therefore belongs to
gen-planalone -- the one flow with the person in it. A plan is handed on decided, and rlcr stays question-free and unchanged.Notes
Decision Status:PENDINGor<User's final decision>`) counts as undecided: a status nobody touched is a decision nobody made.auto_start_rlcr_if_converged's comment -- "nothing left to decide" -- is now enforced rather than assumed.hmz checkon the flow: clean.🤖 Generated with Claude Code