Skip to content

fix(auth): bound web authentication sessions - #1

Merged
humandebri merged 4 commits into
mainfrom
fix/web-auth-session-timeout
Jul 31, 2026
Merged

fix(auth): bound web authentication sessions#1
humandebri merged 4 commits into
mainfrom
fix/web-auth-session-timeout

Conversation

@humandebri

Copy link
Copy Markdown
Owner

Purpose

  • Bound native Internet Identity browser sessions so authentication cannot wait indefinitely.
  • Publish the exact runtime behavior used by KinicWiki 1.0.2 as a reproducible Swift package release.

Changes

  • Add timeout, task-cancellation, and concurrent-attempt handling to ICInternetIdentityAuthenticator.
  • Keep shared browser sessions as the production default while allowing explicit ephemeral test sessions.
  • Add iOS callback, state, duplicate-query, and malformed-payload regression tests.
  • Add macOS and iOS GitHub Actions checks and document the public authentication API.

Verification

  • swift test — 14 tests passed.
  • xcodebuild test on iOS 18.5 Simulator — 19 tests passed.
  • Generic iOS Simulator build-for-testing succeeded.
  • Reviewed exact callback matching, one-time state validation, single completion, timeout cancellation, and concurrent-attempt rejection.

Impact

  • Source-compatible default behavior for existing callers.
  • New public timeout error and optional authentication parameters.
  • No change to the production default browser-session sharing behavior.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@humandebri
humandebri merged commit 642aeb0 into main Jul 31, 2026
3 checks passed
@humandebri
humandebri deleted the fix/web-auth-session-timeout branch July 31, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant