Professionalize and secure dissertation template - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82da6cd699
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if path.name in FORBIDDEN_NAMES and path.name not in ALLOWED_ENV_FILES: | ||
| return "application state or credentials must not be tracked" | ||
| if path.suffix.lower() in FORBIDDEN_SUFFIXES: |
There was a problem hiding this comment.
Reject sensitive filename variants
When a user has .env.local / .env.production or Zotero sidecar files such as zotero.sqlite.bak staged or force-added, this exact-name/suffix check does not flag them; if their contents don't match the narrow secret regexes, make security reports OK even though these are the same credential/application-state files the new public-repo policy is meant to block. Treat the forbidden names as patterns such as .env* except .env.example and zotero.sqlite*, or add equivalent checks here.
Useful? React with 👍 / 👎.
Summary
AGENTS.mdandCLAUDE.mdWhy
The repository is being prepared for public use as a reproducible dissertation research template. The previous documentation and manuscript skeleton did not cover doctoral submission requirements, publication hygiene, or safe external-file workflows.
Impact
maindraft/thesis-config.texValidation
UV_CACHE_DIR=.cache/uv uv run pytest— 39 passedUV_CACHE_DIR=.cache/uv uv run ruff check .UV_CACHE_DIR=.cache/uv uv run ruff format --check .python3 tools/public_repo_check.py --historymake pdf pdf-final supplementarypython3 tools/thesis_check.pySubmission note
The strict submission check intentionally fails while template metadata and manuscript TODOs remain. Authors must replace those values before an actual university submission.