feat: add Prometheus Remote Write v2.0 support, tests, integration, and migration guide#10
Draft
ipe4647 wants to merge 2 commits into
Draft
feat: add Prometheus Remote Write v2.0 support, tests, integration, and migration guide#10ipe4647 wants to merge 2 commits into
ipe4647 wants to merge 2 commits into
Conversation
…nd migration guide - Implements full v2.0 protocol (symbol table, native histograms, metadata, exemplars) - Adds new API: pushTimeseriesV2, pushMetricsV2, serializeV2, etc. - Integration tests with local Prometheus via Docker Compose - Comprehensive documentation and migration guide - Backward compatible with v1.x API - Validated with unit and integration tests - See IMPLEMENTATION.md for full summary
Owner
|
lol) good start, but it is a bummer that it is just a bunch of _v2 files. it should be either separate project / npm library or fully integrated into the existing codebase (i.e. just change config = { version: 2 } or similar) Vibe coding prompt: |
- Deleted index_v2.js and index_v2.test.js files to remove v2 specific code. - Updated package.json to remove test:v2 script. - Modified test-integration.js to use unified API without v2 suffixes. - Enhanced types.d.ts to support new unified API and removed v2 specific types. - Added verification script to ensure refactoring completeness and correctness. - Removed legacy types_v2.d.ts file. - Ensured backward compatibility and auto-detection of protocol version.
Author
|
@huksley Some improvements were made. Please check it. I left the migration guides / implementation notes in for you to validate the AI thought process. IMHO they should be removed or re-written before merging to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB! This all is vibe-coded. The source of the change is prometheus docs and the official proto type. Please be vigilant checking the implementation.
This should resolve #9