Add LoMa keypoint matching model#47401
Conversation
|
Hello @Gitanaskhan26 , thanks for the PR! To note, the weights are provided only in If you are using a code agent: transformers_contribution_skill.md |
Hi @molbap, thanks for the feedback!
Noted. I will handle the
Understood. I will implement the descriptor network as a clean, reusable abstraction so it can be easily shared with other models in the future.
Thanks for sharing, I will make sure to use it! |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, loma |
CI recapDashboard: View test results in Grafana |
What does this PR do?
Fixes #47004
Adds LoMa (davnords/LoMa), a local feature matcher that outperforms LightGlue and is
competitive with dense matchers on standard benchmarks (WxBS, IMC22, HPatches),
accepted at ECCV 2024.
Paper: https://arxiv.org/abs/2604.04931 (base), https://arxiv.org/abs/2604.11809 (rotation-invariant)
Code: https://github.com/davnords/LoMa
This is a work in progress; opening as a draft early per the contribution guide, to
track progress and get feedback before going further.
Scope for this PR
LoMa pairs with several external keypoint detectors in the original repo (DaD, DeDoDe-v2,
DISK, ALIKED), none of which are currently native
transformersmodels, andtrust_remote_codefor non-SuperPoint detectors was removed from LightGlue in #45122 for security reasons.
Proposing to scope this first PR to LoMa + SuperPoint, matching that existing precedent,
and follow up with native detector support (DaD in particular, since it's what the paper's
headline numbers use) as a separate PR once this lands. Flagging this early in case there's
a different preference; happy to adjust scope based on feedback here.
Architectural note: Currently planning to implement the DeDoDe-style descriptor network
as a reusable, standalone component (to enable a future native DeDoDe integration).
Open to feedback on this approach --> see comment in #47004.
Plan
LoMaConfigLoMaForKeypointMatching+ Auto registrationBefore submitting
(Note: Documentation and comprehensive tests are currently unchecked as this is a draft PR. They will be fully implemented and checked in subsequent commits before merging.)
Who can review?
@zucchini-nlp @guarin, @molbap