V0.23 release#2032
Open
ArthurZucker wants to merge 3 commits intomainfrom
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
force-pushed
the
v0.23-release
branch
2 times, most recently
from
a2c316f to
4f81fce
Compare
ArthurZucker
force-pushed
the
v0.23-release
branch
from
afcb1c1 to
63dee40
Compare
ArthurZucker
force-pushed
the
v0.23-release
branch
from
63dee40 to
7f1623b
Compare
Lets us re-cut the npm publish independently of the python/rust
release workflows (which own `v*` and already created the GitHub
Release for 0.23.1, causing `napi prepublish` to 422 on retry).
- trigger: `v*` -> `node-v*`
- split publish into two steps:
- `napi prepublish -t npm --no-gh-release` does the per-platform
`npm publish` from `npm/<triple>/`, skipping the `POST /releases`
call.
- `npm publish --ignore-scripts` publishes the parent package
without re-running the `prepublishOnly` hook.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Set napi.packageName so per-platform sub-packages publish as `@huggingface/tokenizers-<triple>` (e.g. @huggingface/tokenizers-darwin-x64) instead of unscoped `tokenizers-<triple>`. The unscoped names on npm are owned by `n1t0` (Anthony Moi) — the org CI npm token has no publish access there, which is why the 0.23.1 release attempt 404'd on the very first sub-package. The unscoped sub-packages were never successfully published from CI; the only versions on the registry (0.13.4-rc1/rc2) were hand-published by n1t0 and the 0.13.3 stable parent shipped with optionalDependencies that 404 at install (npm tolerates it for optionalDependencies). Parent package stays `tokenizers` — public-facing import name is unchanged. napi regenerates the runtime loader to require the scoped names. Also delete the 13 checked-in `bindings/node/npm/<triple>/` template files. They hardcoded the old unscoped name and version 0.13.4-rc1 and were misleading as source. CI regenerates them via `napi create-npm-dirs` (already in node-release.yml line 213). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR